Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check disp_format and clamp if necessary #203

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

jsalotti
Copy link
Contributor

Problems

  • when creating a Disparity object from a prediction, the tensor contains both positive and negative values. This causes a problem when converting between signed and unsigned disparity format
  • when converting Disparity to Depth, some infinite values can happen in the resulting tensor

Fixes

  • when creating disparity with "signed" format : force user to give camera_side and clip values to have only one sign (positive for right camera, negative for left)
  • when creating disparity with "unsigned" format : clip values to have only positive
  • when converting to depth : add a max_depth parameter to avoid infinite values

@jsalotti jsalotti requested a review from thibo73800 July 18, 2022 09:27
@jsalotti jsalotti self-assigned this Jul 18, 2022
@thibo73800 thibo73800 requested a review from Data-Iab July 19, 2022 06:03
@jsalotti jsalotti changed the title wip: check disp_format and clamp if necessary check disp_format and clamp if necessary Jul 19, 2022
@thibo73800 thibo73800 merged commit 22f455e into master Jul 20, 2022
@thibo73800 thibo73800 deleted the fix_disparity_sign branch July 20, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants