-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
43 panoptic quality metrics #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this pull request should be merged ? It look there is a lot of overlap with an other pull request I just reviewed
@staticmethod | ||
def __new__(cls, x, labels: Union[dict, Labels] = None, *args, **kwargs): | ||
# Load frame from path | ||
if isinstance(x, str): | ||
x = load_mask(x) | ||
kwargs["names"] = ("N", "H", "W") | ||
tensor = super().__new__(cls, x, *args, **kwargs) | ||
tensor.add_label("labels", labels, align_dim=["N"], mergeable=False) | ||
tensor.add_label("labels", labels, align_dim=["N"], mergeable=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what is the reason for using mergeable True for the labels ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thibo73800 , actually I see BoundingBoxes2d have the labels as mergeable. so i used the same logic
…sk2id Fix compute pq metric mask2id
…ior/aloception into 43-panoptic-quality-metrics
@thibo73800 I updated PQmetric, fixing a problem in calculus. Now is ready to merge |
Development of
PQmetric
andPQMetricsCallback
modules, to measure Panoptic Quality metric.Important changes:
CocoPanopticDataset
to read and handled multiples labels: ['category','isthing','supercategory']ApMetricsCallbacks
andPQMetricsCallbacks
base onBaseMetricsCallbacks
, in order to use any metric withadd_sample
function.LitPanopticDetr
and createPanopticApMetricsCallbacks
, that transform (if the procedure required it) the labels inaloscene.Labels
object (keep only 'category' label)', to handled the same pipeline that Detr model.aloscene.Mask.masks2id
function (calledaloscene.Mask.masks2panoptic
before) to return annotations (use just inget_view
function) if desired and fix silence problem in wrong changes of ids.Some problems fixed:
aloscene.Mask.getview
: Render aloscene.BoundingBoxes2d and aloscene.Mask from multiples labels. Tested cases:Important note:
This feature requires first approve and merge #73. The changes present in the new update not mentioned are part of #73
Closes #43