Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DBMD #25

Closed
VoidXH opened this issue Oct 7, 2022 · 35 comments
Closed

Add support for DBMD #25

VoidXH opened this issue Oct 7, 2022 · 35 comments
Assignees

Comments

@VoidXH
Copy link
Owner

VoidXH commented Oct 7, 2022

Requested by @ValZapod. Dolby Atmos Metadata, needed for DME imports. Should be a manual selection as "ADM BWF + DBMD". If all else fails, loading a donor file's DBMD will work.

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 19, 2022

Hi @ValZapod, please try to import a file to DME created by the version in c0ac027.

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 19, 2022

What if you change defaultCreationInfo in DolbyMetadata.cs to "Created using Dolby equipment"? That is the original value in DBMDs, but I wanted to try first without it.

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 20, 2022

Finally some error messages that actually say something, I can fix these. Thank you! Could you please also try if the defaultCreationInfo is just "Dolby"? I should put a different text there if I can.

@bluewidy
Copy link

bluewidy commented Oct 20, 2022

If I change defaultCreationInfo to Created using Dolby equipment or Dolby, I get the following error in both.
the result

One thing I found is that the error message displayed by DaVinci Resolve is the same as the error message displayed by the Dolby Atmos Conversion Tool.
Dolby Atmos Conversion Tool errer_message

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 20, 2022

Alright, thanks for trying.

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 21, 2022

What about cf3c40f?

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 21, 2022

Please try with de71f1d. If this doesn't work (all metadata is supported now), please send me a file that does.

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 22, 2022

It's not the missing DBMD then, but another header. Doesn't really need a new issue though.

@bluewidy
Copy link

Sir, I also found something.
Dolby Atmos conversion tool errer_message

@bluewidy
Copy link

bluewidy commented Oct 22, 2022

Thank you, Thank you so much VoidXH! I never thought you would implement this feature in such a short period of time.
DaVinci Resolve no longer cries! It works fantastic XD
Here's a video https://drive.google.com/file/d/1Lx2ceLH2EzRg4nfPRPkSrhZ3fnjT98MS/view?usp=sharing
EAC3-JOC to Dolby Atmos Master

@bluewidy
Copy link

bluewidy commented Oct 22, 2022

If the audio stream of the EAC3-JOC is too long, it seems to create the master file abnormally. I created an Atmos master file from EAC3-JOC of 2 hours and 2 minutes, and the audio duration of the output master file is 7 minutes and 39 seconds.
something wrong
So I tried to import it into DaVinci Resolve, but I got the following error
DaVinci Resolve cries again

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 22, 2022

Found and reverted the commit that broke the framerate. Please build from f9c531d.

@bluewidy
Copy link

I have a question every time you post some weird alphabets from time to time. Do I have to build it myself? Or can I just download it here http://cavern.sbence.hu/?

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 22, 2022

Yes, you have to build it or change the DLLs to the automatic builds.

@bluewidy
Copy link

Still getting the same error, sir.
same error

@bluewidy
Copy link

bluewidy commented Oct 22, 2022

I created an Atmos master file from EAC3-JOC of 2 hours and 2 minutes

I'm researching this issue and I think I've found something... I shredded the two hour and two minute audio stream. The problem does not occur when I create a master file with fragments of the audio stream from 0 to 2 minutes. And when I create a master file with fragments of the audio stream from 4 to 6 minutes, no problem. However, when I created a master file from fragments of an audio stream from 2 to 3 minutes, I got this error : Must be a valid ADM BWF file.
In other words, audio streams that exist at certain times of the EAC3-JOC are what confuses Cavernize.

@bluewidy
Copy link

Here is a sample file for not working timezones. I have succeeded in narrowing the scope with super precision!
https://drive.google.com/file/d/1eGIet8kp0qBYiUYfuaT7RNsD4QaVRv0S/view?usp=sharing

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 22, 2022

Found the undocumented location of the timecode. New version released on the site with full DBMD support.

@VoidXH VoidXH closed this as completed Oct 22, 2022
@bluewidy
Copy link

bluewidy commented Oct 23, 2022

Here is a sample file for not working timezones. I have succeeded in narrowing the scope with super precision! https://drive.google.com/file/d/1eGIet8kp0qBYiUYfuaT7RNsD4QaVRv0S/view?usp=sharing

error

error2

But this sample still doesn't work.

@bluewidy
Copy link

bluewidy commented Oct 23, 2022

@ValZapod What is your purpose of obtaining ADM BWF files? Maybe... this?

decode EAC3 and encode TrueHD Atmos.

My goal is to export Atmos binaural audio via DaVinci Resolve using an ADM BWF file.

@bluewidy
Copy link

But this sample still doesn't work.

You can ignore this message. I've come up with another new alternative. #40

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 23, 2022

But this sample still doesn't work.

This was encoded before the fix. Try again.

@bluewidy
Copy link

I also tested it on Star wars sample

Oh! Mine is Star trek. We have one thing in common, "Star".

@VoidXH
Copy link
Owner Author

VoidXH commented Oct 25, 2022

Another timing commit, another release on the site. Please try with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@VoidXH @bluewidy and others