Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Grafana 11.0.0 and dependencies #164

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Updated Grafana 11.0.0 and dependencies #164

merged 3 commits into from
Jun 4, 2024

Conversation

mikhail-vl
Copy link
Member

@mikhail-vl mikhail-vl commented Jun 4, 2024

Mocking was recommend for another Virtual to upgrade to the latest release: TanStack/virtual#641 (comment).

This is expected as in jsdom environment getBoundingClientRect will return height 0 for scroller element. There few options we can tackle this, one is to mock getBoundingClientRect using vi.fn have a look at https://github.com/TanStack/virtual/issues/641#issuecomment-1902239048

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 4, 2024
@mikhail-vl mikhail-vl added this to the Version 3.1.0 milestone Jun 4, 2024
@mikhail-vl mikhail-vl requested a review from asimonok June 4, 2024 02:36
@mikhail-vl mikhail-vl self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (5b82459) to head (b899a56).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          60       60           
  Lines        1279     1279           
  Branches      371      327   -44     
=======================================
  Hits         1260     1260           
- Misses         18       19    +1     
+ Partials        1        0    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Mock tanstack/virtual is still unsuitable for the current implementation so let's keep the current version

@mikhail-vl mikhail-vl merged commit 08e0d42 into main Jun 4, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/grafana-11 branch June 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants