From 35e5461079d7dae48a06bcc38091d52754e7b076 Mon Sep 17 00:00:00 2001 From: yonatankra Date: Mon, 7 Jun 2021 16:49:41 +0300 Subject: [PATCH 1/2] Fix the documentation --- components/data-grid/readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/data-grid/readme.md b/components/data-grid/readme.md index 46eea8045..fa7a8918d 100644 --- a/components/data-grid/readme.md +++ b/components/data-grid/readme.md @@ -39,7 +39,7 @@ There are 2 ways to supply data to grid, via the following grid component proper - simplest - all data upfront - suitable for small to medium amounts of data (in terms of memory occupation) -- `dataProvider: (params: { page: number, pageSize: number }, callback: (pageItems: unknown[], totalItems?: number) => void) => void` +- `dataProvider: (params: { page: number, pageSize: number }, callback: (pageItems: unknown[], totalItems: number) => void) => void` - stream of chunks, on demand - should be used when memory usage concern present (from the data perspective) - should be used when pulling data from the backend on the fly @@ -326,4 +326,4 @@ const cellRenderer = (container, column, data) { ``` Pay attention, how the columns data structure is not maintained in JS anymore. -Moreover, attributes like `sortable`, `auto-width` etc can be binded to some data structure managed be data-binding framework, thus removing the whole customization part out of scripting scope. \ No newline at end of file +Moreover, attributes like `sortable`, `auto-width` etc can be binded to some data structure managed be data-binding framework, thus removing the whole customization part out of scripting scope. From 4ac1c4510a00078acb3f40c27eb5ea45add75cf0 Mon Sep 17 00:00:00 2001 From: Yuri Guller Date: Mon, 7 Jun 2021 17:10:09 +0300 Subject: [PATCH 2/2] Update components/data-grid/readme.md --- components/data-grid/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/data-grid/readme.md b/components/data-grid/readme.md index fa7a8918d..93aa4ac98 100644 --- a/components/data-grid/readme.md +++ b/components/data-grid/readme.md @@ -326,4 +326,4 @@ const cellRenderer = (container, column, data) { ``` Pay attention, how the columns data structure is not maintained in JS anymore. -Moreover, attributes like `sortable`, `auto-width` etc can be binded to some data structure managed be data-binding framework, thus removing the whole customization part out of scripting scope. +Moreover, attributes like `sortable`, `auto-width` etc can be bound to some data structure managed by data-binding framework, thus removing the whole customization part out of the scripting scope.