Skip to content

Conversation

@behei-vonage
Copy link
Contributor

What is this PR doing?

This PR fixes an issue where VERA does not display special characters properly in Participant List, Muted Video Publisher.

How should this be manually tested?

To reproduce the issue, run the app on the develop branch.
Join the waiting room and try using a name that involves a special character for username, such as Òscar followed by a last name of your choice.
Mute your video in the waiting room and notice that the initial displayed is only for the "last name" part of it.
Join the meeting room, add another tab.
Mute video on the tab A.
From tab B, notice that the initials displayed only contain the "last name" part of the user A.
Notice that the little image in the participant list of user A in the user B tab shows as only having the "last name" part of it.

To reproduce the fix, checkout this branch.
Perform the steps above and notice that special character is used as part of the intitials.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-10

Checklist

[ ] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@behei-vonage behei-vonage self-assigned this Sep 4, 2025
v-kpheng
v-kpheng previously approved these changes Sep 4, 2025
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

It's Beautiful! 😭

v-kpheng
v-kpheng previously approved these changes Sep 5, 2025
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just have a few comments/questions. Let me know what you think!


expect(initials).toBe('АШ');
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for unicode emojis? It's supported in the SDK, I'm not sure what the behavior is in VERA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the behavior in the SDK seems strange. It supports only one emoji as tested with meet. For VERA, if someone does add some emoji such as 🇫🇷 François 🎨 García it'll use FG for initials without displaying any emojis. hope that works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No love for 🇱🇦 😢 ?
JK! 😆

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀


expect(initials).toBe('АШ');
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No love for 🇱🇦 😢 ?
JK! 😆

@dwivedisachin
Copy link
Contributor

Tested LGTM!! 🚀

@dwivedisachin dwivedisachin merged commit 4470ab5 into develop Sep 10, 2025
7 checks passed
@dwivedisachin dwivedisachin deleted the behei-vonage/vidsol-10-special branch September 10, 2025 18:13
behei-vonage added a commit that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants