-
Notifications
You must be signed in to change notification settings - Fork 9
VIDSOL-10: VERA does not display special characters properly in Participant List, Muted Video Publisher #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💪 🚀
It's Beautiful! 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💪 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Just have a few comments/questions. Let me know what you think!
|
|
||
| expect(initials).toBe('АШ'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test for unicode emojis? It's supported in the SDK, I'm not sure what the behavior is in VERA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the behavior in the SDK seems strange. It supports only one emoji as tested with meet. For VERA, if someone does add some emoji such as 🇫🇷 François 🎨 García it'll use FG for initials without displaying any emojis. hope that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No love for 🇱🇦 😢 ?
JK! 😆
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Great job! ![]()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💪 🚀
|
|
||
| expect(initials).toBe('АШ'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No love for 🇱🇦 😢 ?
JK! 😆
|
Tested LGTM!! 🚀 |
…cipant List, Muted Video Publisher (#210)



What is this PR doing?
This PR fixes an issue where VERA does not display special characters properly in Participant List, Muted Video Publisher.
How should this be manually tested?
To reproduce the issue, run the app on the
developbranch.Join the waiting room and try using a name that involves a special character for username, such as
Òscarfollowed by a last name of your choice.Mute your video in the waiting room and notice that the initial displayed is only for the "last name" part of it.
Join the meeting room, add another tab.
Mute video on the tab A.
From tab B, notice that the initials displayed only contain the "last name" part of the user A.
Notice that the little image in the participant list of user A in the user B tab shows as only having the "last name" part of it.
To reproduce the fix, checkout this branch.
Perform the steps above and notice that special character is used as part of the intitials.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-10
Checklist
[ ] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?