VIDSOL-281: refactor app config context for scoped reactivity and stable rests #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny-quesada-developer
changed the base branch from
main
to
johnny/vidsol-280-unit-test-fixes-and-refinements
johnny-quesada-developer
force-pushed
the
johnny/vidsol-VIDSOL-281-refactor-AppConfigContext-for-scoped-reactivity-and-stable-rests
branch
from
a4c1660 to
57d7614
Compare
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
a0d05c8 to
6d8ac7f
Compare
johnny-quesada-developer
force-pushed
the
johnny/vidsol-VIDSOL-281-refactor-AppConfigContext-for-scoped-reactivity-and-stable-rests
branch
from
57d7614 to
b10a7fc
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 83 out of 84 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/components/HiddenParticipantsTile/HiddenParticipantsTile.spec.tsx
Outdated
Show resolved
Hide resolved
johnny-quesada-developer
force-pushed
the
johnny/vidsol-VIDSOL-281-refactor-AppConfigContext-for-scoped-reactivity-and-stable-rests
branch
3 times, most recently
from
2182b81 to
77170d3
Compare
- using granular context for app configuration... avoid re-renders and isolate logic - adding reusable provider wrappers for unit test - removing a bunch of mocks in our unit test... mocking our own code downgrades the quality of the test
johnny-quesada-developer
force-pushed
the
johnny/vidsol-VIDSOL-281-refactor-AppConfigContext-for-scoped-reactivity-and-stable-rests
branch
from
77170d3 to
55e2440
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR refactors the AppConfigContext to isolate updates and stop global re-renders.
It forces components to subscribe only to the specific configuration keys they depend on, eliminating unnecessary re-renders and improving overall performance.
It also introduces the isAppConfigLoaded flag to stabilize initialization and prevent UI flickers.
Additionally, it removes excessive mocking from our test suite to improve reliability and ensure tests reflect real behavior.
This change lays the groundwork for future low-code/no-code configuration flows, where the AppConfigContext will become more dynamic and require granular state updates.
How should this be manually tested?
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-281
Checklist
[x] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?