-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec deprecatedReplaceInURN #117
Conversation
spec.bs
Outdated
[=node navigable=]'s [=navigable/traversable navigable=]'s | ||
[=traversable navigable/fenced frame config mapping=]. | ||
|
||
1. Let |config| be the result of [=fenced frame config mapping/finding a config=] in |mapping| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems wrong to do this synchronously, and seems to not match what the implementation does, since the implementation does this "in parallel" and returns a promise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I should make this a promise...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned this into a promise, modeling after some parts of the Protected Audience spec. Lmk if it I didn't do it right.
@@ -1222,6 +1222,78 @@ Each {{FencedFrameConfig}} has: | |||
1. Initialize |value|'s [=fencedframeconfig/contentHeight=] to |serialized|.\[[ContentHeight]]. | |||
</div> | |||
|
|||
To help with ease of adoption, | |||
[until 2026](https://github.com/WICG/turtledove/issues/286#issuecomment-1682842636) we will support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it sound like we're actually indeed removing the API in 2026. Are we? Or are we just "deprecating" it softly then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been deprecated since it was added, hence the name. It should actually be removed in several years.
SHA: 3b93e20 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview | Diff