Add NetworkTable Source. #572
Conversation
This reads a boolean, number, or string value from a NetworkTable key and makes it available to GRIP.
|
Note: I didn't create a new source icon for this so that should be changed before merging. |
| return true; | ||
| } else { | ||
| return false; // No output sockets were updated | ||
| } |
There was a problem hiding this comment.
There is a lot of duplicate code here. Is there any way to generify it?
There was a problem hiding this comment.
I was thinking of refactoring the type-specific handling to an internal class to make it a bit cleaner and get rid of the null assignments, but I don't know how much code can be deduplicated because fundamentally there are different types and thus different function calls required in this section in particular.
|
The thing that I dislike about this PR is that network tables creates static state which can cause cascading test failures that are really hard to debug/track down. I've been working on trying to isolate network tables from our class hierarchy by exclusively having any reference to it in our This means that I can provide a mock |
|
I'm certainly okay with changing this to use NTManager, although the amount of introspection used there means it may take me a bit to do it. Will you be at champs this week? We can discuss in person too. |
|
I will not. I have to submit my MQP paper by Thursday and have several other projects I need to finish up before the end of the term. I'm open to a hangouts call or similar at any point. Send me a message on Gitter and we can chat. |
| } | ||
|
|
||
| @Override | ||
| public void initialize() { |
There was a problem hiding this comment.
* Add operation to save image snapshots to local disk. The period and path prefix and suffix can be set, and the operation enabled and disabled at will (this is particularly useful in combination with PR #572).
|
Closing in favor of #646 |
This reads a boolean, number, or string value from a NetworkTable key and
makes it available to GRIP.