Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]#4-Dev 생성 #5

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[Settings]#4-Dev 생성 #5

merged 1 commit into from
Feb 6, 2024

Conversation

VesselWheel
Copy link
Contributor

@VesselWheel VesselWheel commented Feb 6, 2024 •
edited
Loading

  • WeatherDataModel이 포함된 dev branch 생성입니다.

@VesselWheel VesselWheel self-assigned this Feb 6, 2024
RACHEL056
RACHEL056 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@RACHEL056 RACHEL056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev 브랜치 초기 세팅이 다 완료된 것 같습니다!

hay-dev24
hay-dev24 approved these changes Feb 6, 2024
View reviewed changes
Copy link

@hay-dev24 hay-dev24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 감사합니다 화이팅!!!!! 🥰

SeokJin-0318
SeokJin-0318 reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@SeokJin-0318 SeokJin-0318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅇㅇ

dave17code
dave17code approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@dave17code dave17code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인

SeokJin-0318
SeokJin-0318 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@SeokJin-0318 SeokJin-0318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅇㅇ

RACHEL056
RACHEL056 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@RACHEL056 RACHEL056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거를 이렇게 끝내는 걸까요?

Weather777/Network/WeatherModel.swift
let coord: Coord
let weather: [Weather]
let base: String
let main: Main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 왜 안될까요

RACHEL056
RACHEL056 reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@RACHEL056 RACHEL056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 해보겠습니다

Weather777/Network/WeatherModel.swift
let cod: Int
}

// MARK: - Clouds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 코멘트를 해야할까요?

@hay-dev24 hay-dev24 self-requested a review February 6, 2024 04:01
@VesselWheel VesselWheel merged commit 072de93 into main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RACHEL056 RACHEL056 RACHEL056 approved these changes

@dave17code dave17code dave17code approved these changes

@SeokJin-0318 SeokJin-0318 SeokJin-0318 approved these changes

@hay-dev24 hay-dev24 hay-dev24 approved these changes

Assignees

@VesselWheel VesselWheel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VesselWheel @hay-dev24 @RACHEL056 @SeokJin-0318 @dave17code