-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch order of load/store immediates in binary format #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleynh
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Jun 27, 2022
Account for changes in WebAssembly/multi-memory#29
alexcrichton
added a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Jun 27, 2022
* Swap multi-memory order of offset/memory index Account for changes in WebAssembly/multi-memory#29 * Fix some tests
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Aug 12, 2022
WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Aug 22, 2022
WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Aug 22, 2022
WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
code-terror
pushed a commit
to code-terror/wasm-tools
that referenced
this pull request
Aug 24, 2022
* Swap multi-memory order of offset/memory index Account for changes in WebAssembly/multi-memory#29 * Fix some tests
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Nov 15, 2022
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Dec 22, 2022
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
May 26, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
May 26, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
May 26, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
May 26, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Jun 20, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
keithw
added a commit
to WebAssembly/wabt
that referenced
this pull request
Aug 26, 2023
The testsuite now requires supporting global.get in elem exprs (WebAssembly/spec#1641), and the multi-memory proposal flipped the order of memory indexes on memory.copy (WebAssembly/multi-memory#29).
keithw
added a commit
to WebAssembly/wabt
that referenced
this pull request
Aug 26, 2023
The testsuite now requires supporting global.get in elem exprs (WebAssembly/spec#1641), and the multi-memory proposal flipped the order of memory indexes on memory.copy (WebAssembly/multi-memory#29).
keithw
added a commit
to WebAssembly/wabt
that referenced
this pull request
Sep 11, 2023
keithw
added a commit
to WebAssembly/wabt
that referenced
this pull request
Sep 11, 2023
Reflects change in the multi-memory proposal: WebAssembly/multi-memory#29
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Dec 5, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Dec 5, 2023
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Jan 4, 2024
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
added a commit
to second-state/WasmEdge-unittest
that referenced
this pull request
Mar 25, 2024
Update: WebAssembly/multi-memory#29 Signed-off-by: YiYing He <yiying@secondstate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28.
@ashleynh, PTAL.