Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch order of load/store immediates in binary format #29

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

rossberg
Copy link
Member

Fix #28.

@ashleynh, PTAL.

Copy link
Contributor

@ashleynh ashleynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rossberg rossberg merged commit e303f90 into main Jun 27, 2022
@rossberg rossberg deleted the mem-immediate branch June 27, 2022 19:36
alexcrichton added a commit to alexcrichton/wasm-tools that referenced this pull request Jun 27, 2022
alexcrichton added a commit to bytecodealliance/wasm-tools that referenced this pull request Jun 27, 2022
* Swap multi-memory order of offset/memory index

Account for changes in WebAssembly/multi-memory#29

* Fix some tests
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Aug 12, 2022
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Aug 22, 2022
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Aug 22, 2022
code-terror pushed a commit to code-terror/wasm-tools that referenced this pull request Aug 24, 2022
* Swap multi-memory order of offset/memory index

Account for changes in WebAssembly/multi-memory#29

* Fix some tests
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Nov 15, 2022
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Dec 22, 2022
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request May 26, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request May 26, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request May 26, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request May 26, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Jun 20, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
keithw added a commit to WebAssembly/wabt that referenced this pull request Aug 26, 2023
The testsuite now requires supporting global.get in elem exprs
(WebAssembly/spec#1641), and the multi-memory
proposal flipped the order of memory indexes on memory.copy
(WebAssembly/multi-memory#29).
keithw added a commit to WebAssembly/wabt that referenced this pull request Aug 26, 2023
The testsuite now requires supporting global.get in elem exprs
(WebAssembly/spec#1641), and the multi-memory
proposal flipped the order of memory indexes on memory.copy
(WebAssembly/multi-memory#29).
keithw added a commit to WebAssembly/wabt that referenced this pull request Sep 11, 2023
keithw added a commit to WebAssembly/wabt that referenced this pull request Sep 11, 2023
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Dec 5, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Dec 5, 2023
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Jan 4, 2024
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
q82419 added a commit to second-state/WasmEdge-unittest that referenced this pull request Mar 25, 2024
Update: WebAssembly/multi-memory#29

Signed-off-by: YiYing He <yiying@secondstate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contradiction in multi-memory binary format instruction rules
2 participants