Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Desynchronization After 1.21.1 Update - Locked Maps Lose Pixels #406

Closed
Aurbey opened this issue Oct 18, 2024 · 8 comments
Closed

Map Desynchronization After 1.21.1 Update - Locked Maps Lose Pixels #406

Aurbey opened this issue Oct 18, 2024 · 8 comments
Labels
platform: spigot This issue is specific to Spigot/Paper priority: medium This issue will be looked at when available type: bug This issue is about something that isn't working as intended

Comments

@Aurbey
Copy link

Aurbey commented Oct 18, 2024

Description: After updating my Minecraft servers to version 1.21.1, I've encountered an issue with HuskSync where locked maps do not sync properly between servers. Prior to the update, everything worked flawlessly, but now maps lose pixels after traveling between servers.

Steps to Reproduce:

  1. Create a locked map on one server (in my case, the Arts server).
  2. Teleport to another server (in my setup, it's the Farms server) with HuskSync active.
  3. Open the same locked map after synchronization.

Expected Behavior: The locked map should appear identical across servers without any visual issues.

Actual Behavior: The map loses pixels or shows visual corruption after syncing between servers, as if some pixel data is not being transferred correctly. Attached are screenshots comparing the same map before and after synchronization:

Screenshot 1: Normal map after creation.
image

Screenshot 2: The same map after traveling between servers.
image

Server Details:

  • HuskSync version: HuskSync-Paper-3.7+mc.1.21.1
  • Minecraft server version: 1.21.1 (using Velocity 3.3.0-SNAPSHOT and Purpur servers 2324 build)
  • Relevant plugin configuration: Haven't updated since 1.20.4 where everything worked fine.

No errors in the logs.
Redis and MySQL are configured and working fine

Additional Information: I have tried replicating the issue on a fresh server setup, and the problem persists. This issue did not occur on version 1.20.x, and no other plugin changes have been made. Could this be related to how map data is serialized or synced after the update?

Potential Cause/Idea: The issue seems to be related to how HuskSync handles the new map format or locked map data in 1.21.1. Perhaps some data fields are missing or incorrectly handled during the synchronization process.(Assumption.)

@FlizZ27

This comment was marked as spam.

@WiIIiam278 WiIIiam278 added type: bug This issue is about something that isn't working as intended priority: medium This issue will be looked at when available platform: spigot This issue is specific to Spigot/Paper labels Oct 18, 2024
@WiIIiam278
Copy link
Owner

Thanks for the detailed report & for bringing this to my attention.

On inspection of the wiki, it seems an undocumented change to the Map format was made in the 1.20.6 update cycle. This will require an investigation. https://minecraft.wiki/w/Map#History

@Aurbey

This comment was marked as spam.

@twisti-dev

This comment was marked as spam.

@WiIIiam278 WiIIiam278 reopened this Nov 4, 2024
@RillSoji
Copy link

RillSoji commented Nov 6, 2024

We are experiencing this issue as well. Let me know if we can help in any way.

Running Paper 1.21.1#131
Velocity#449
HuskSync 3.7

@WiIIiam278
Copy link
Owner

This issue should now be fixed. Download the latest alpha from William278.net and test.

WiIIiam278 added a commit that referenced this issue Nov 14, 2024
WiIIiam278 added a commit that referenced this issue Nov 14, 2024
WiIIiam278 added a commit that referenced this issue Nov 14, 2024
WiIIiam278 added a commit that referenced this issue Nov 14, 2024
@Aurbey
Copy link
Author

Aurbey commented Nov 17, 2024

This issue should now be fixed. Download the latest alpha from William278.net and test.

I compile this plugin from your sources. And I get an error when loading the server. I understand that this is caused by the fact that the plugin is compiled for version 1.21.3. How to fix it?

@WiIIiam278
Copy link
Owner

We don't provide compile support here unfortunately, please open a ticket on discord with proof of purchase :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: spigot This issue is specific to Spigot/Paper priority: medium This issue will be looked at when available type: bug This issue is about something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

5 participants