Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5. Feature/adding slide in training modules #5914

Conversation

omChauhanDev
Copy link
Contributor

What this PR does

This pr help user in adding slides to training modules via dashboard.

The logic for adding slides to training modules is dipicted by this flow diagram :
Logical Diagram final

Screenshots

Before:

Before

After:

  1. Add slide button
    After

  2. Modal for adding slide
    1  Fillign form

  3. Slide added
    2  Slided added

  4. Validations :

  • V1 : One slug cannot be taken by two training web pages
    image

  • V2 : Multiple addition of same slide is not allowed
    image

  • V3 : No field should be empty
    image

@omChauhanDev omChauhanDev changed the title Feature/adding slide in training modules 5. Feature/adding slide in training modules Jul 30, 2024
@omChauhanDev omChauhanDev force-pushed the feature/adding-slide-in-training_modules branch from cb542d8 to a488647 Compare July 30, 2024 14:57
@ragesoss
Copy link
Member

This works as expected for me. I think it needs to handle the wiki pages a little more flexibly, accept either just the page title or the complete URL, and extracting the page title if a full URL is submitted.

@ragesoss ragesoss merged commit 08ce977 into WikiEducationFoundation:Om-Training Aug 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants