-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raised for testing purpose - Contains all code of GSoC 2024 #5946
base: master
Are you sure you want to change the base?
Raised for testing purpose - Contains all code of GSoC 2024 #5946
Conversation
…ture/switch-edit-view-mode-in-training Feature/switch edit view mode in training
…ture/add-module-to-training-library 3. feature/add-module-to-training-library-using-dashboard
…ture/transfer-module-between-categories 4. feature/transferring training modules between categories
…ture/adding-slide-in-training_modules 5. Feature/adding slide in training modules
This is an impressive set of functionality. I've done some initial testing, and there are a few UX problems that I think will need to be fixed before this is ready to deploy.
|
I also encountered a JS error when entering 'reorder' mode on an existing module's index page:
|
Fixing this error and also reducing some unnecessary lines of code of 'reordering slides' pr. Then will move on to incorporating the listed changes to make it perfect for deployment. |
sir, where you found this error as, I tried replicating this error in my browser console but found nothing |
@ragesoss sir, kindly have a look |
Hmm... I still hit that same error. I'm doing this in wiki_education mode, with freshly reloaded training modules, and any time I click 'Change Order' on the index page of one of the YAML-backed modules, it throws a JS error and the React-rendered sidebar disappears. |
What this PR does
This pr is created for testing all training modification features.
Eg: how they work over production server