Tooltips and Popovers #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also causes the entire Water Column to be on top of value wells on narrow screens, but that is a problem for a future redesign effort. Refs #17
When a popover is shown below the thumbnail, the arrow is aligned with the title which has a prominent, non- white background color. A plain white arrow looks starkly out of place. To fix this, we add the NLCD / Soil group name to the arrow, and if and only if the popover is shown below the thumbnail, we use the title color's arrow. Else, we show the regular white arrow, which goes better with the popover body.
Previously all the popovers would open to the left of the thumbnail, uniformly. This unfortunately occluded the main content. To avoid that, now we open the popover of the left-most thumbnail of every row to the right. For all the NLCD thumbnails, the popover is opened below them. For the Soil thumbnails, the popover is opened above. This works well for all cases except the right-most ones, whose content is a little squished for lack of room. This may be an acceptable compromise given the client's needs. Refs #19
|
Tagging @designmatty for design review. |
designmatty
approved these changes
Jun 30, 2020
According to this recommendation: https://www.shellcheck.net/wiki/SC2230
mmcfarland
approved these changes
Jun 30, 2020
|
Thanks for reviewing! We have #21 for tackling that overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensures that water column tooltips are always on top. Also ensures that thumbnail popovers do not obscure the main content.
See commit messages for details.
Connects #17
Connects #19
Demo
Tooltips on top:
Non-obscuring popovers:
Testing Instructions
./scripts/setup.shvagrant ssh -c 'cd /vagrant && ./scripts/bundle.sh --debug'vagrant ssh -c 'cd /vagrant && ./scripts/server.sh'