We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to dispose of FileStreams: using FileStream fs = File.Create(LogFilePath); fs.Close();
Should add await Task.Run:
public async void Log(LogLevel level, string message) { await Task.Run(() => { if (level >= MinLevel) { var cloudLog = new CloudLog() { Severity = level.ToString(), Message = message, Timestamp = DateTime.UtcNow };
Send(LogFilePath, cloudLog, Resolver.MeadowCloudService.SendLog); } });
}
Fix memory leak in MeadowCloudService.SendLog and SendEvent where HttpResponseMessage and StringContent are not being disposed of
@bryancostanich , I tried to contribute by fixing this and the MeadowCloudLog but wasn't able to branch and create a pull request
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Need to dispose of FileStreams:
using FileStream fs = File.Create(LogFilePath);
fs.Close();
Should add await Task.Run:
public async void Log(LogLevel level, string message)
{
await Task.Run(() =>
{
if (level >= MinLevel)
{
var cloudLog = new CloudLog()
{
Severity = level.ToString(),
Message = message,
Timestamp = DateTime.UtcNow
};
}
Fix memory leak in MeadowCloudService.SendLog and SendEvent where HttpResponseMessage and StringContent are not being disposed of
@bryancostanich , I tried to contribute by fixing this and the MeadowCloudLog but wasn't able to branch and create a pull request
The text was updated successfully, but these errors were encountered: