Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would using treesitter help here? #9

Closed
IndianBoy42 opened this issue Jul 8, 2021 · 2 comments
Closed

Would using treesitter help here? #9

IndianBoy42 opened this issue Jul 8, 2021 · 2 comments

Comments

@IndianBoy42
Copy link

A large collection of language parsers, generates rust bindings, good performance and error recovery
@Wilfred
Copy link
Owner

Wilfred commented Jul 17, 2021

Yeah, I think it's worth exploring. Treesitter seems to have sufficient structure for my needs (e.g. including comments in the AST). Also, I'm already getting bored of parser fixes in syntax.toml :P

I want to focus on getting the tree diffing logic solid at this point. Computing the changes and printing them in a coherent way is already non-trivial, and there's more work to do here.

I will look at treesitter in future though. It would be a matter of converting the treesitter AST to difftastic's AST, and it should hopefully just work.

@Wilfred Wilfred closed this as completed Jul 17, 2021
@Wilfred Wilfred mentioned this issue Jul 19, 2021
Closed
@Wilfred
Copy link
Owner

Wilfred commented Aug 29, 2021

FWIW difftastic now uses tree-sitter parsing by default :)

Wilfred pushed a commit that referenced this issue Sep 6, 2021
@ananthakumaran
handle newline before and after dot
014fa28 
fixes #9
Wilfred pushed a commit that referenced this issue Jan 30, 2022
@theHamsta
Upgrade to tree_sitter 0.20.1 (#9)
4b86b07
Wilfred pushed a commit that referenced this issue Feb 3, 2022
@frankeld
ts-parse and test-dir QOL improvements (#9)
090c145 
## ts-parse

Allows easy task to regen parser before running the normal parse

Test of behavior of mix of `&&` and `{` / `}` in ts-parse
- If bin/generate-parser fails, then ts-parse fails
- If bin/generate-parser succeeds, then the parse result is output regardless of error status

## test-dir
Makes more specific extension/header checking and adds some helpful info
Wilfred pushed a commit that referenced this issue Mar 20, 2022
@UserNobody14
Merge pull request #9 from akinsho/unhide-final-const-var-nodes
07fc459 
Unhide final and const nodes
igorclark pushed a commit to igorclark/difftastic that referenced this issue Mar 28, 2022
@ahlinc
fix: Parser hunging, close Wilfred#9, close Wilfred#2 (Wilfred#10)
9d5fd0c
jbr pushed a commit to jbr/difftastic that referenced this issue Mar 30, 2022
@the-mikedavis
use fields for left,operator,right of binary expressions (Wilfred#9)
d68eab5
Wilfred pushed a commit that referenced this issue Apr 14, 2022
@fwcd
Merge pull request #9 from fwcd/annotated-class-parameter
d98e200 
Improve support for annotations
ido77778 pushed a commit to ido77778/difftastic that referenced this issue May 3, 2022
@JoranHonig
Merge pull request Wilfred#9 from JoranHonig/cleanup_ast
5b7f3ec 
🎨  Improve structure of the ast for literals
Wilfred pushed a commit that referenced this issue Jul 11, 2022
@m-novikov
Merge pull request #9 from m-novikov/punctuation
245cb15 
Initial punctuation support
Wilfred pushed a commit that referenced this issue Jan 26, 2023
@jimhester
Add license
bcf381c 
Fixes #9
Wilfred pushed a commit that referenced this issue Mar 16, 2023
@Decodetalkers
fix(escape): \; should also be escape sequences (#9)
6e51463 
Towards to
https://cmake.org/cmake/help/latest/manual/cmake-language.7.html, "\;"
is also escape sequences
grunweg pushed a commit to grunweg/difftastic that referenced this issue May 5, 2023
@pfoerster
Merge pull request Wilfred#9 from vitorof/some-fixes
2c0d03a 
mixed_group addition and biblatex_include fix
Thecentury pushed a commit to Thecentury/difftastic that referenced this issue Jan 27, 2024
@vzarytovskii
Update tests baselines (Wilfred#9)
96ecf71
blmaier pushed a commit to blmaier/difftastic that referenced this issue Feb 13, 2024
@joelspadin
Merge pull request Wilfred#9 from nickcoutsos/delete-with-name-field
cc26cbf 
Define 'name' field for /delete-node/ and /delete-property/
Duologic pushed a commit to Duologic/difftastic that referenced this issue Mar 22, 2024
Fix priority if-then-else (Wilfred#9)
7b2847a 
This also lays the ground work for fixing the priority
for the binary operators in another PR.

This closes sourcegraph/tree-sitter-jsonnet#6

test plan:
make test
novusnota added a commit to novusnota-forks/difftastic that referenced this issue Aug 25, 2024
@novusnota
fix: highlighting for Helix + remove TLB field (Wilfred#9)
319a322 
* chore[helix]: removed excessive queries which made highlighting worse

* fix: Remove unwanted field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wilfred @IndianBoy42