Optimization for eliminating redundant memory operations #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wilfred
added a commit
that referenced
this pull request
Jun 12, 2022
This is sufficient, and we were spending a lot of time in this function in the sample files from #297.
|
Looks like the performance regression was between 0.28 and 0.29. |
|
Bisect points to 57a4b6d, which will need analysing further. |
Wilfred
added a commit
that referenced
this pull request
Jun 13, 2022
It looks like we were allocating large buffers for wu-diff, and mimalloc performance is much worse for this case in the new version. This reverts performance back to that 0.28 for large files, such as the example in #297.
|
Should be fixed now, thanks for the great bug report! |
Merged
Wilfred
pushed a commit
that referenced
this pull request
Mar 16, 2023
Wilfred
pushed a commit
that referenced
this pull request
Jun 13, 2023
Structural types in declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization for eliminating redundant memory operations by changing LineNumber to u32.
#293 (comment)
At first I tried to make changes on the latest version, but I found that the latest version was running much slower than the 0.23.0 version that I initially used for testing and modifying (about 3m23s to 4s, which is about 50x slowdown). So now I only submit a pull request based on the 0.23.0 version (commit afb1b36)
These two attachments are the files I used for testing. Please let me know if you have any suggestions.
test.cpp.txt
test2.cpp.txt