-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jsonnet support #676
Open
Duologic
wants to merge
17
commits into
Wilfred:master
Choose a base branch
from
Duologic:jsonnet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Jsonnet support #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes sourcegraph/tree-sitter-jsonnet#5 test plan: make test
* support 'tailstrict' call annotation This is used in the standard jsonnet library (std.jsonnet) test plan: make test * add node for tailstrict
This also lays the ground work for fixing the priority for the binary operators in another PR. This closes sourcegraph/tree-sitter-jsonnet#6 test plan: make test
Followed the official spec for the precedence values. test plan: make test
test plan: make test
* style: fmt * refactor: cleaner $.expr + match order to abstract syntax (from jsonnet spec)
* fix: compare with 'in' operator * fix: use field in object for loop * test: add examples from Wilfred#13 as tests * test: update test case following suggestion in Wilfred#13
* refactor: replace (expr) with more specific names * chore: make generate * feat: add/improve queries * docs: add syntax.jsonnet example
@Wilfred Are you still open for adding more languages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the manual, I hope I did it right. It worked on my machine™