Add support for Windows arm64 prebuilds
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be becoming a necessity now since Windows is getting popular on arm64 devices.
All of the supported runtime versions were tested at
better-sqlite3-multiple-ciphers(successful workflow run).🟡 As seen in the diff, Node arm64 build needed a custom command since there aren't any official Windows arm64 headers available for Node till Node v20 (https://nodejs.org/dist/v20.0.0). So for the moment, we can only build against Windows arm64 for Node v20 upwards. We can clean up the build process once Node v18 has reached EOL.