Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming and adding a description to the subject of the rack editor #118

Closed
2 tasks done
xOpasik opened this issue Sep 4, 2022 · 20 comments · Fixed by #122
Closed
2 tasks done

Naming and adding a description to the subject of the rack editor #118

xOpasik opened this issue Sep 4, 2022 · 20 comments · Fixed by #122
Labels
NF-0: Accepted Accepted Status NF-3: Implementation - Done Implementation: Done and Tested Locally Work in Progress Things I am currently taking a look at

Comments

@xOpasik
Copy link

xOpasik commented Sep 4, 2022

Is your feature request related to a problem?

To enable the crafting of this item

Describe the solution you'd like.

I would like to ask you to add the possibility:

  • Item naming for editing stands
  • Adding a description
  • Adding any enchant

Describe alternatives you've considered.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other

No response

@Wolfieheart
Copy link
Owner

  • Item naming for editing stands
    Can you please further clarify as to what you mean by this as Naming ArmorStands is already apart of the Base Pack

  • Adding a description
    Can you clarify this?

  • Adding any enchant
    This might be tricking and something that I am not comfortable adding at this moment

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

This is what I wrote about with you over a month ago

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

image

Ability to name and add an item description in config

@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 12, 2022 via email

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

Oh, sorry that I dare to write and remind you.

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

After a month, I remind you, because I'm just waiting to be able to introduce this player editor.

Have I written to you day by day about it? A month without asking, reminders, is a long period

@Wolfieheart
Copy link
Owner

I understand. I am sorry for putting it off for so long but other priorities at the moment. I will try to have a look into this today :)

@Wolfieheart
Copy link
Owner

Checking already in to stuff I need to do:

Item Descriptions as you call it are already available through the Lore feature that this plugin has available. Thats per research on the SpigotMC Forums

The Item Name I will look into adding now :)

@Wolfieheart Wolfieheart added NF-0: Accepted Accepted Status NF-1: Implementation - Pending Implementation: Pending Status Work in Progress Things I am currently taking a look at NF-0: Pending Investigation New Features: Pending Investigation labels Sep 12, 2022
@Wolfieheart Wolfieheart linked a pull request Sep 12, 2022 that will close this issue
4 tasks
@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 12, 2022

#122 will close this and will require some testing from my side but I can not test it right now as I am at work and have worked on this over lunch :)

If you want to attempt to test this yourself, then please do so by downloading https://cdn.discordapp.com/attachments/942106460207337563/1018849097656057856/armorstandeditor-1.19.2-37.3.jar

And setting the 2 Variables Regarding requireToolName and the toolName itself and renaming your tool in an Anvil or giving yourself a tool with that name.

@Wolfieheart Wolfieheart added NF-3: Implementation - Done Implementation: Done and Tested Locally and removed NF-1: Implementation - Pending Implementation: Pending Status NF-0: Pending Investigation New Features: Pending Investigation labels Sep 12, 2022
@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

image

So it is supposed to work on the principle, you add a description in the item and after that it is "searched"?

Can you make any name you want?

@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 12, 2022 via email

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

In fact, great if a hex gradient was implemented sometime

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

image

@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 12, 2022 via email

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

requireToolLore: true
toolLore: '&7testowy'

And what to do when I want to make 1-2 lines of description?

@xOpasik
Copy link
Author

xOpasik commented Sep 12, 2022

Out of curiosity, did you remove the server discord or, under the influence of emotions, did you ban me?

@Wolfieheart
Copy link
Owner

Wolfieheart commented Sep 12, 2022 via email

@Wolfieheart
Copy link
Owner

This has now been tested and will be closed when #122 is merged in :) Expect it to be available in a few hours

Wolfieheart added a commit that referenced this issue Sep 12, 2022
* [CORE] Add in Functionality for Custom Names

* [CORE] Bump to 1.19.2-37.3

* [CORE] Bump to 1.19.2-37.3

* [CORE] Bump PlotSquared to 6.9.4

* [CORE] Optimize Imports

* [CORE] Fix Bugs in Implementation Part 1 - Objests.RequireNonNull

* [CORE] Fix Bug in Checking String Comparison

* [CORE] Fix Build Compliation due to incorrect variable

* [CORE] Bump to 1.19.2-38 - After Debug Fixes.

Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>

Signed-off-by: Wolfieheart <xmakeitrain94@gmail.com>
@xOpasik
Copy link
Author

xOpasik commented Sep 13, 2022

In fact, yes, fact, I also tested myself and it worked, but I did not write forgive

@Wolfieheart
Copy link
Owner

No worries, thank you for testing and again I apologise for the long delay with waiting to get this done. :) It shouldnt happen in the future and I have begun work to finalise 1.19.2-38 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NF-0: Accepted Accepted Status NF-3: Implementation - Done Implementation: Done and Tested Locally Work in Progress Things I am currently taking a look at
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants