From 2f94311b5ce88d37530090a056c88c3bac949068 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ann=20=E6=9D=8F=20Kilzer?= Date: Mon, 12 Oct 2020 00:50:50 +0900 Subject: [PATCH 1/7] initial work on carousel for press --- web/src/components/press/PressCarousel.vue | 70 ++++++++++++++++++++++ web/src/views/Home.vue | 4 +- 2 files changed, 73 insertions(+), 1 deletion(-) create mode 100644 web/src/components/press/PressCarousel.vue diff --git a/web/src/components/press/PressCarousel.vue b/web/src/components/press/PressCarousel.vue new file mode 100644 index 00000000..7ff8ab62 --- /dev/null +++ b/web/src/components/press/PressCarousel.vue @@ -0,0 +1,70 @@ + + + diff --git a/web/src/views/Home.vue b/web/src/views/Home.vue index 3b93e7be..3f9c1352 100644 --- a/web/src/views/Home.vue +++ b/web/src/views/Home.vue @@ -28,7 +28,7 @@
- + @@ -38,12 +38,14 @@ import Illustration from '@/components/hero/Illustration.vue'; import CallToAction from '@/components/hero/CallToAction.vue'; import Summary from '@/components/about/Summary.vue'; import FindSpeaker from '@/views/FindSpeaker.vue'; +import PressCarousel from '@/components/press/PressCarousel.vue'; export default { name: 'Home', components: { Illustration, CallToAction, + PressCarousel, Summary, FindSpeaker, }, From f275794fbf56fe70a2252d15b5dc8e7af6048fa8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ann=20=E6=9D=8F=20Kilzer?= Date: Mon, 12 Oct 2020 01:01:09 +0900 Subject: [PATCH 2/7] add title and spacing --- web/src/components/about/Summary.vue | 2 +- web/src/components/press/PressSection.vue | 21 +++++++++++++++++++++ web/src/views/Home.vue | 7 ++++--- 3 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 web/src/components/press/PressSection.vue diff --git a/web/src/components/about/Summary.vue b/web/src/components/about/Summary.vue index f413b051..e71f7984 100644 --- a/web/src/components/about/Summary.vue +++ b/web/src/components/about/Summary.vue @@ -13,7 +13,7 @@ +
+ +

Press coverage

+
+ +
+ + + diff --git a/web/src/views/Home.vue b/web/src/views/Home.vue index 3f9c1352..18694b27 100644 --- a/web/src/views/Home.vue +++ b/web/src/views/Home.vue @@ -28,7 +28,8 @@
- + + @@ -38,14 +39,14 @@ import Illustration from '@/components/hero/Illustration.vue'; import CallToAction from '@/components/hero/CallToAction.vue'; import Summary from '@/components/about/Summary.vue'; import FindSpeaker from '@/views/FindSpeaker.vue'; -import PressCarousel from '@/components/press/PressCarousel.vue'; +import PressSection from '@/components/press/PressSection.vue'; export default { name: 'Home', components: { Illustration, CallToAction, - PressCarousel, + PressSection, Summary, FindSpeaker, }, From 52ff32f5f3e94eb01c920dc4f49d6730e355cc45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ann=20=E6=9D=8F=20Kilzer?= Date: Sat, 31 Oct 2020 16:15:47 +0900 Subject: [PATCH 3/7] add another source --- web/src/components/press/PressCarousel.vue | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/web/src/components/press/PressCarousel.vue b/web/src/components/press/PressCarousel.vue index 7ff8ab62..5f7eb5cb 100644 --- a/web/src/components/press/PressCarousel.vue +++ b/web/src/components/press/PressCarousel.vue @@ -8,6 +8,7 @@ - {{ item.quote }} + {{ item.quote }} + + + {{ item.name }} @@ -52,13 +58,15 @@ export default { press: [ { image: 'https://cdn.japantimes.2xx.jp/wp-content/uploads/2017/03/new-JT-logo.jpg', // TODO: Is this okay to fetch from their CDN? + name: 'The Japan Times', quote: '"...SpeakHer aims to assist event organizers by providing a free bilingual database of public speakers in Japan who are women."', link: 'https://www.japantimes.co.jp/community/2020/09/28/issues/speakher-manels-women/', }, { - image: 'https://cdn.japantimes.2xx.jp/wp-content/uploads/2017/03/new-JT-logo.jpg', - quote: 'Lorum Ipsum', - link: 'http://www.example.com', + image: 'https://japanbyrivercruise.com/assets/images/image01.png?v88719225713061', + name: 'Japan By River Cruise Podcast', + quote: 'A List of Women (w/Yan Fan)', + link: 'https://share.transistor.fm/s/f53eaea0', }, ], }; From 0e298e4fcc46012be78385382bb634b1f190bcf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ann=20=E6=9D=8F=20Kilzer?= Date: Sat, 31 Oct 2020 16:25:26 +0900 Subject: [PATCH 4/7] link + quote fix --- web/src/components/press/PressCarousel.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/web/src/components/press/PressCarousel.vue b/web/src/components/press/PressCarousel.vue index 5f7eb5cb..3b1dcd78 100644 --- a/web/src/components/press/PressCarousel.vue +++ b/web/src/components/press/PressCarousel.vue @@ -8,6 +8,8 @@ Date: Sat, 31 Oct 2020 16:46:39 +0900 Subject: [PATCH 5/7] mobile fix --- web/src/components/press/PressCarousel.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/src/components/press/PressCarousel.vue b/web/src/components/press/PressCarousel.vue index 3b1dcd78..267a76ae 100644 --- a/web/src/components/press/PressCarousel.vue +++ b/web/src/components/press/PressCarousel.vue @@ -17,10 +17,10 @@ height="100%" > - + From c26cb1ffcba5897559e093307e7490cd2a71d8bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ann=20=E6=9D=8F=20Kilzer?= Date: Sat, 31 Oct 2020 17:03:28 +0900 Subject: [PATCH 6/7] checkpoint --- web/src/components/press/PressCarousel.vue | 2 +- web/src/components/press/PressSection.vue | 13 ++++++++++--- web/src/i18n/locales/en.json | 3 +++ web/src/styles/main.scss | 5 +++++ web/src/views/Home.vue | 1 - 5 files changed, 19 insertions(+), 5 deletions(-) diff --git a/web/src/components/press/PressCarousel.vue b/web/src/components/press/PressCarousel.vue index 267a76ae..c5c130d5 100644 --- a/web/src/components/press/PressCarousel.vue +++ b/web/src/components/press/PressCarousel.vue @@ -20,7 +20,7 @@ fill-height fluid > - + -
+ -

Press coverage

+

+ {{ $t('press.title') }} +

-
+