Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonces on several places #623

Closed
6 tasks done
zzap opened this issue Nov 17, 2022 · 6 comments
Closed
6 tasks done

Nonces on several places #623

zzap opened this issue Nov 17, 2022 · 6 comments
Assignees
Labels
APIs Issues for Common APIs Handbook developer documentation (DevHub) Improvements or additions to developer documentation migration from Codex Migrating content from Codex to HelpHub/DevHub. plugins Issues for Plugin Developer Handbook themes Issues for Theme Developer Handbook

Comments

@zzap
Copy link
Member

zzap commented Nov 17, 2022

Issue Description

Information about nonces can be found on 3 different places: Codex, Themes and Plugins handbooks. There is no difference in using nonceses in plugins and themes. It's how we do things in WordPress generally. This kind of functionality is the reason we have Common APIs handbook and that's where all that data should be moved.

URL of the Page with the Issue

Why is this a problem?

Because this info should live in one place. It's the same for all WordPress developers.

Suggested Fix

  • Review all the info we currently have, from all 3 places.
  • Keep content that is up to date, remove outdated and add new if applicable.
  • Create meaningful new page or pages in Common APIs for it.
  • Remove duplicates from Theme and Plugins handbooks, keep what's unique for both. Do NOT delete pages.
  • Link from Themes and Plugins handbooks to newly created Common APIs page(s).
  • Retire Codex page - by removing complete content and adding link to a newly created Common APIs page(s).
@zzap zzap added developer documentation (DevHub) Improvements or additions to developer documentation plugins Issues for Plugin Developer Handbook themes Issues for Theme Developer Handbook APIs Issues for Common APIs Handbook migration from Codex Migrating content from Codex to HelpHub/DevHub. labels Nov 17, 2022
@github-actions
Copy link

Heads up @kafleg @carolinan @TeBenachi - the "themes" label was applied to this issue.

@github-actions
Copy link

Heads up @zzap - the "apis" label was applied to this issue.

@github-actions
Copy link

Heads up @theMikeD - the "plugins" label was applied to this issue.

@theMikeD theMikeD self-assigned this Dec 3, 2022
@theMikeD
Copy link

theMikeD commented Dec 3, 2022

Updated nonces is here https://developer.wordpress.org/apis/security/nonces/

@theMikeD
Copy link

theMikeD commented Dec 5, 2022

The Theme and Plugin handbook pages for nonces have been updated with references to the API handbook.

I can't edit the Codex pages so @zzap can you do those for me please?

@zzap
Copy link
Member Author

zzap commented Dec 6, 2022

Edited Codex page: https://codex.wordpress.org/WordPress_Nonces

Thank you @theMikeD ❤️

@zzap zzap closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIs Issues for Common APIs Handbook developer documentation (DevHub) Improvements or additions to developer documentation migration from Codex Migrating content from Codex to HelpHub/DevHub. plugins Issues for Plugin Developer Handbook themes Issues for Theme Developer Handbook
Projects
None yet
Development

No branches or pull requests

2 participants