Move "is assignment" related utility to dedicated VariableHelper
#2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "is assignment" related utility method is only used by a small set of sniffs, so is better placed in a dedicated class. As this method also expects a `T_VARIABLE` token as input, the `VariableHelper` class seems appropriate. This commit moves the `is_assignment()` method to the new `WordPressCS\WordPress\Helpers\VariableHelper` and starts using that class in the relevant sniffs. Related to 1465
dingo-d
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "is assignment" related utility method is only used by a small set of sniffs, so is better placed in a dedicated class.
As this method also primarily expects a
T_VARIABLEtoken as input, theVariableHelperclass seems appropriate.This commit moves the
is_assignment()method to the newWordPressCS\WordPress\Helpers\VariableHelperand starts using that class in the relevant sniffs.Related to #1465