Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with example-block-style-js #10

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix issue with example-block-style-js #10

merged 1 commit into from
Dec 10, 2023

Conversation

juanmaguitar
Copy link
Collaborator

@juanmaguitar juanmaguitar commented Dec 9, 2023 •
edited
Loading

FIxes #9
Also specify WP 6.4 for wp-env

The styles weren't added to the iframe so this PR solves this issue with the use of enqueue_block_assets

As of WordPress 6.3, all assets added through the enqueue_block_assets PHP action will also be enqueued in the iframed Editor. See #48286 for more details (source: Enqueueing assets in the Editor)

@juanmaguitar juanmaguitar merged commit 3f04a36 into master Dec 10, 2023
@justintadlock justintadlock mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justintadlock justintadlock Awaiting requested review from justintadlock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example-block-style-js doesn't display proper style in the block editor
1 participant
@juanmaguitar