From 0d277b5045e8eee1f30359d6913441846bd3a709 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Fri, 15 Jul 2022 09:02:59 +0200 Subject: [PATCH] Change document actions title heading level. --- .../specs/site-editor/multi-entity-editing.test.js | 2 +- .../src/components/header/document-actions/index.js | 2 +- .../src/components/header/document-actions/style.scss | 10 +++------- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/packages/e2e-tests/specs/site-editor/multi-entity-editing.test.js b/packages/e2e-tests/specs/site-editor/multi-entity-editing.test.js index 18af53555216af..212ddbb955682d 100644 --- a/packages/e2e-tests/specs/site-editor/multi-entity-editing.test.js +++ b/packages/e2e-tests/specs/site-editor/multi-entity-editing.test.js @@ -216,7 +216,7 @@ describe( 'Multi-entity editor states', () => { templateName ); await page.waitForXPath( - `//h1[contains(@class, "edit-site-document-actions__title") and contains(text(), '${ templateName }')]` + `//h2[contains(@class, "edit-site-document-actions__title") and contains(text(), '${ templateName }')]` ); removeErrorMocks(); diff --git a/packages/edit-site/src/components/header/document-actions/index.js b/packages/edit-site/src/components/header/document-actions/index.js index 449f7b98ee8a25..e94bcdb3dc2567 100644 --- a/packages/edit-site/src/components/header/document-actions/index.js +++ b/packages/edit-site/src/components/header/document-actions/index.js @@ -118,7 +118,7 @@ export default function DocumentActions( { { sprintf( diff --git a/packages/edit-site/src/components/header/document-actions/style.scss b/packages/edit-site/src/components/header/document-actions/style.scss index b83a65938b19a7..c29c576d4b5796 100644 --- a/packages/edit-site/src/components/header/document-actions/style.scss +++ b/packages/edit-site/src/components/header/document-actions/style.scss @@ -30,17 +30,13 @@ } } - .edit-site-document-actions__title-wrapper > h1 { - margin: 0; - - // See comment above about min-width - min-width: 0; - } - .edit-site-document-actions__title { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; + + // See comment above about min-width + min-width: 0; } .edit-site-document-actions__secondary-item {