From 38001c6926fdfa51a69676ebca252bbee1801c55 Mon Sep 17 00:00:00 2001 From: Joen Asmussen Date: Tue, 13 Nov 2018 11:23:21 +0100 Subject: [PATCH] Fix regression with unclickable block warnings (#11768) * Fix regression with unclickable block warnings Fixes #11764. This PR makes the "Resolve" and "Convert to HTML" buttons clickable again. * Add comments. --- packages/editor/src/components/block-list/style.scss | 8 +++++++- packages/editor/src/components/warning/style.scss | 1 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/editor/src/components/block-list/style.scss b/packages/editor/src/components/block-list/style.scss index a1f80ddf8c9ee9..0413805e023aba 100644 --- a/packages/editor/src/components/block-list/style.scss +++ b/packages/editor/src/components/block-list/style.scss @@ -201,10 +201,16 @@ // Warnings &.has-warning .editor-block-list__block-edit { - > :not(.editor-warning) { + // When a block has a warning, you shouldn't be able to manipulate the contents. + > * { pointer-events: none; user-select: none; } + + // Allow the warning action buttons to be manipulable. + .editor-warning { + pointer-events: all; + } } &.has-warning:not(.is-hovered) .editor-block-list__block-edit::before { diff --git a/packages/editor/src/components/warning/style.scss b/packages/editor/src/components/warning/style.scss index bf1ae88e5e07c9..ecfb3f0c99770f 100644 --- a/packages/editor/src/components/warning/style.scss +++ b/packages/editor/src/components/warning/style.scss @@ -34,7 +34,6 @@ .editor-warning__action { margin: 0 6px 0 0; - margin-left: 0; } }