Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpha support for ColorPalette custom color #27960

Closed
amir2mi opened this issue Jan 2, 2021 · 3 comments · May be fixed by #30493
Closed

Alpha support for ColorPalette custom color #27960

amir2mi opened this issue Jan 2, 2021 · 3 comments · May be fixed by #30493
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@amir2mi
Copy link
Contributor

amir2mi commented Jan 2, 2021

Hi is there any option for adding alpha support to ColorPalette custom color, color picker?
This component is quite practical and saves developers from working and wasting time with ColorPicker.
But the limitation for this component is just alpha support and I searched for it but did not find anything related.

colorpalette
@bph bph added [Type] Question Questions about the design or development of the editor. [Feature] UI Components Impacts or related to the UI component system labels Jan 4, 2021
@niklasp niklasp mentioned this issue Apr 3, 2021
Open
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 3, 2021
niklasp added a commit to niklasp/gutenberg that referenced this issue Apr 13, 2021
@niklasp
Enable color palettes with custom color alpha support
0284283 
ColorPicker component already had alpha support. Added a `disableAlpha` prop to the `<ColorPalette>` that passes the prop to the ColorPicker. Fix WordPress#27960 WordPress#13045
@mupic
Copy link

mupic commented May 17, 2021

This is a very necessary change that I personally keep waiting for about a year now and it is very strange that it was not supported from the very beginning.

@amir2mi
Copy link
Contributor Author

amir2mi commented May 18, 2021

@mupic Probably forgotten. As I tried the color picker of experimental gradient picker supports this feature.

@amir2mi amir2mi mentioned this issue Jul 4, 2021
Closed
@skorasaurus skorasaurus added [Type] Enhancement A suggestion for improvement. and removed [Type] Question Questions about the design or development of the editor. labels Jul 17, 2021
@skorasaurus
Copy link
Member

Hi, I believe this can be closed because alpha support is included by default in the color picker.

Your pull request is still applicable as far as I know.

Please reopen if I missed understood.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable color palettes with custom color alpha support niklasp/gutenberg
4 participants
@bph @skorasaurus @mupic @amir2mi