-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab unexpectedly highlights "Add block" instead of indenting unordered list #4181
Comments
I'm missing some context here but I recall this being discussed and we decided to avoid it for accessibility reasons (Avoid tab trap). Maybe @jasmussen and @afercia could tell us more. |
See for example #1621 The difference with the classic editor is that a list is always within TinyMCE, so users can always press Enter - Backspace or "exit" the list by other means and have the Tab key back to its default behavior. |
Closing as "won't fix" for now |
Worth noting that this is the behavior for both Dropbox Paper and Google Docs too. |
Also:
This seems like an implementation detail, not a refutation of the expected user experience. |
Also, one could argue that there's a tap trap in the current editor as well. Since you could have meta boxes and stuff like that after TinyMCE. |
Certainly. I don't expect there to be an immediate decision on this; rather, I think it's best we surface all of these little details for deliberate consideration before they're imposed upon tens of thousands of users who have existing usage patterns. |
I'm fine reopening if this is something we want to rediscuss/reconsider? cc @afercia |
Question, can enter/backspace not exit the list here? If not then that might be the issue to fix perhaps? |
Actually, on Google Docs, the recommended shortcut is Cmd/Ctrl + [ or ]. Yes, it works with Tab too but in a Google Doc it is easily possible to "exit" a list with arrows or Enter and avoid to be trapped.
The "expected user experience" when pressing Tab is the default behavior 🙂 moving focus to the next focusable element. Gutenberg lives withing a Web application, it is not a "full editor" like Google Docs. In this case, the default behavior of Tab should not be altered. |
We can agree to disagree then. In this case, I think the current user experience is the expected user experience. |
Ran into this again today. It's pretty frustrating to not be able to indent lists with tab. |
Agree, it feels totally wrong to not be able to indent lists with tab. Are there any other ways to ensure accessibility that allows us to keep the default list creation behavior? |
I'd just like to remind everyone this is not Word or a similar desktop application. Gutenberg (and WordPress itself) is a Web application. On the web, Tab just navigates through focusable fields. That's a native behavior that shouldn't be broken. I can only recommend (as previously said) an alternate shortcut. Worth also reminding a great part of the users will just click the indent / outdent buttons. |
I've created #7051 as follow-up to this issue. /Cc @getsource |
As a Gutenberg user, I'd expect that using the
tab
button within an existing unordered list would increase the indent level.Here's the behavior in the existing editor:
In Gutenberg, the same keystroke pattern triggers the "Add block" UI instead of indenting the list:
This is Firefox Quantum 57.0.1 on Mac.
The text was updated successfully, but these errors were encountered: