Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTML element option for Cover block. #46926

Closed
EldarAgalarov opened this issue Jan 6, 2023 · 3 comments · Fixed by #46969
Closed

Add support for HTML element option for Cover block. #46926

EldarAgalarov opened this issue Jan 6, 2023 · 3 comments · Fixed by #46969
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@EldarAgalarov
Copy link

Group block have HTML ELEMENT option for html tags picking different than div.
Cover block doesn't have such option. Both blocks are container blocks so Cover block should have this option too.

@carolinan carolinan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. labels Jan 6, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Jan 8, 2023

I looked up the blocks where the HTML element option is supported. In my opinion, it would be better if the cover block supported 7 elements as well as the group block.

div header main section article aside footer
core/group ✅(default)
core/template-part
core/comments ✅(default)
core/query ✅(default)

@carolinan carolinan self-assigned this Jan 9, 2023
@carolinan
Copy link
Contributor

I'd prefer to exclude <main>, to avoid it being used by mistake?

@t-hamano
Copy link
Contributor

t-hamano commented Jan 9, 2023

I'd prefer to exclude

, to avoid it being used by mistake?

I think there are users who would like to include a pattern image in the background of the main area. However, it is difficult to say whether this is a common use case.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants