Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to close Link UI unless in "edit" mode #47544

Open
getdave opened this issue Jan 30, 2023 · 4 comments
Open

No way to close Link UI unless in "edit" mode #47544

getdave opened this issue Jan 30, 2023 · 4 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@getdave
Copy link
Contributor

getdave commented Jan 30, 2023

Currently the "Cancel" button is only displayed when you are in editing mode. This will close the UI. However if you are simply previewing the link (and not editing) there is no means of closing the UI other than clicking away.

I believe it is this which causes problems for users of assistive tech. Seems related to #47327.


When editing a link, there's no 'cancel' option unless you're currently editing; the preview state of a link isn't cancellable. If a keyboard user tabs into the link control panel, they aren't offered a clear way to exit.

Originally posted by @joedolson in #47310 (comment)

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Needs design efforts. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jan 30, 2023
@richtabor
Copy link
Member

they aren't offered a clear way to exit.

Is esc not clear/standard?

@joedolson
Copy link
Contributor

esc is standard, but requires prior knowledge to be aware that it's available. Particularly for users with cognitive impairments, having a clearly labeled control to exit is important. Giving users a perceivable exit path supports users who don't know the invisible exits (clicking outside of the UI or Esc).

@getdave
Copy link
Contributor Author

getdave commented May 24, 2023

@richtabor I think we should review the designs in #50891 with the a11y team and see if there's anything that has been missed.

I would recommend that we do the ground work to come up with a list of potential a11y concerns and ask them for their feedback on these. If there is any additional feedback we can also look into that.

Happy to help with this.

@richtabor
Copy link
Member

@richtabor I think we should review the designs in #50891 with the a11y team and see if there's anything that has been missed.

Just closing the loop that we've conducted the review per #50950

@richtabor richtabor removed the Needs Design Needs design efforts. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants