Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation > add search block > description is mandatory and its style cannot be deactivated #48410

Closed
Marc-pi opened this issue Feb 24, 2023 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.

Comments

@Marc-pi
Copy link

Marc-pi commented Feb 24, 2023

Description

related to #41549

  • block background color is different between Site Editor view vs Front side
  • description is mandatory : people cannot only set the search icon within the nav
  • if no description is set, the search block takes too much place !!! and there is no way to reduce its width (just display the icon)
  • border is always visible

IMHO, a quick improvement is needed for 6.2 for user UX, to make it usable / clean (to not make any new WP user angry)
ping @annezazu (FSE Outreach)

Step-by-step reproduction instructions

Just add the search block within the nav component (here in the header partial part)

Screenshots, screen recording, code snippet

Site editor / nav view (edit partial part / header) Front view
image image

Environment info

  • WP 6.1.1
  • Gutenberg 15.2.0
  • TT2 theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@getdave getdave changed the title Navigation > add search block > description is mandatory and its style cannot be deactivated (ugly XP) Navigation > add search block > description is mandatory and its style cannot be deactivated Feb 24, 2023
@getdave
Copy link
Contributor

getdave commented Feb 24, 2023

Thanks for reporting this. I trust you will understand I've removed the term "ugly" from the Issue title as it is quite emotive.

Question: would you be able to verify whether this is a bug that was present in WP 6.1 or is it something introduced during the 6.2 cycle?

I appreciate these UX issues can be frustrating, but there are many priorities and thus we have to be selective in which issues we will focus on. Of course, a pull request to fix this Issue would be greatly received by the community 🙇

@Marc-pi
Copy link
Author

Marc-pi commented Feb 24, 2023

  • i've just tested the new nav component in real condition, as if i were a newbie just onboarding on wordpress (like my customers).
  • Improving the navigation component was indeed on top target for 6.2,
  • Adding the search in the navigation is a very common usage (quite every website)
  • A quick fix on this is a quickwin for the project, the probability that a wp user is struggled by this point is high!

So i do think this must be fixed asap, just to credit the hard work done by everyone for this release and ease the Gutenberg adoption. Having such a use case not working just discredits the efforts.
We stated that phase 2 is about to be closed, for me many small areas like this one need to be fixed.
Of course, we can fix this with custom css, but here the issue is more about the text placeholder.
I do know everyone is busy, but this point is major if we consider promoting Gutenberg is our target !

Moreover, I do think we need to test GB through the whole editing process, now that single components are quite all mature/done, to be sure that we cover common use case with efficiency.

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field labels Feb 28, 2023
@annezazu
Copy link
Contributor

I tried replicating this with WP 6.6.1 and GB 19.1 using this WordPress playground link and I wasn't able to replicate:

search.button.color.mov

Specifically, the colors matched in the editor and on the front end. I'm going to close this out as a result but please let me know if I missed something about this issue.

@Marc-pi
Copy link
Author

Marc-pi commented Aug 31, 2024

@annezazu things have been improved in between since Gutenberg 15.2 ;-à
there is just an inconcistencies in the Editor when clicking on the "button only" option, we have to insist and click twice to make it effective, but we can live with it
we can close

@annezazu
Copy link
Contributor

annezazu commented Sep 2, 2024

@Marc-pi ah ha! I see some oddness there and opened a new issue for that here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants