Site logo looks off when editing site (templates, etc.) only

[janboddez]

Description

The icon fills up all the space (while the "focus box" does not, see screenshot). On other screens, like the Edit Post one, it still looks like before, i.e., smaller. (Again, see screenshot.)

Actually, it looks OK on the "template selection" screen as well; it's the actual Site Editor screens (where you edit the templates, etc.) that are "different."

In fact, some of the icon is cut off along all four sides (it is hard to see).

I understand this may have been done on purpose and can actually look okay for certain images (photos with some of margin around the "main subject") but it came as quite a surprise.

Step-by-step reproduction instructions

I had a site logo set (using the Site Logo block, make sure "logo" is selected when saving, so that it actually updates), and then moved from WP 6.2 to 6.3. That's when the change occured.

Screenshots, screen recording, code snippet

The Site Editor situation is shown on the left, the "regular" block editor on the right. The left icon is way larger while the link's "focus outline" is not.

Environment info

• WP 6.3-RC2
• Firefox 115.0.3
• Windows 10

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[annezazu]

Using 6.3 RC3, I'm seeing and replicating the following:

• In the Site Editor, the logo is larger and has a smaller lift in terms of animation for pages and templates.
• In the Post Editor, the logo is smaller and upon hovering, it has more room for animation.

TLDR: The animations and dimensions are different. I don't think this is intentional and I find the post editor animations to be better:

logo.mov

I'm going to add to the 6.3 board but it seems to be a good candidate for 6.3.x+ as it's not a major bug if it's not able to be quickly addressed.

[ndiego]

I feel like this has been the case for a while, and I agree that the post Editor implementation is generally better for the logos I have used. Given that this is not a breaking change and RC3 is today, I think we should punt to 6.3.x

[annezazu]

Agreed. Thanks for double checking. Moving to 6.3.x.

[kevin940726]

I think this is an intentional design choice made in #48886. Perhaps @richtabor or @mtias could provide more details about it?

I believe the cut-off comes from the code here:

gutenberg/packages/edit-site/src/components/layout/style.scss

Lines 216 to 217 in b2e5f0d

	height: $grid-unit-80;
	width: $grid-unit-80;

...where $grid-unit-80 is 64px, but the parent container's size is defined here:

gutenberg/packages/edit-site/src/components/site-hub/style.scss

Lines 46 to 47 in b2e5f0d

	height: $header-height;
	width: $header-height;

which is 60px.

The inconsistency here is probably what makes it "look off".

[mtias]

Yeah, the post editor is not opening a sidebar so it already works a bit differently. It'll be reconciled as we reconcile other parts of the site / post editors.