Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: .otf font files are rejected. #54759

Closed
matiasbenedetto opened this issue Sep 23, 2023 · 2 comments · Fixed by #54886
Closed

Font Library: .otf font files are rejected. #54759

matiasbenedetto opened this issue Sep 23, 2023 · 2 comments · Fixed by #54886
Assignees
@madhusudhand
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended

Comments

@matiasbenedetto
Copy link
Contributor

After the latest mime type checks implemented, the .otf files are rejected by the server.

Testing

In this screencast, I'm running:

  • WordPress 6.3
  • Gutenberg trunk
  • PHP Version 8.1.23
  • Apache 2
  • Ubuntu 22.04
  • Firefox browser

Result:
❎ .otf files no uploading.

The rest of the file types work OK.
✅ .ttf files
✅ .woff files
✅ .woff2 files

In this zip file you can find 5 different font files with otf file extension:
otf fonts.zip

Screencast of the test

2023-09-23.14-46-59.mp4
@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Feature] Fonts API labels Sep 24, 2023
@matiasbenedetto matiasbenedetto moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Sep 25, 2023
@matiasbenedetto matiasbenedetto added [Feature] Typography Font and typography-related issues and PRs and removed [Feature] Fonts API labels Sep 25, 2023
@madhusudhand
Copy link
Member

madhusudhand commented Sep 25, 2023 •
edited
Loading

While testing, for some otf files, mime type was application/vnd.ms-opentype instead of font/otf. Since only one type can be used, we can either switch the mime type or drop the otf support for now and add in the future versions.

Created #54780 [draft] to drop the support for this release.

@madhusudhand madhusudhand mentioned this issue Sep 25, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 25, 2023
@matiasbenedetto matiasbenedetto mentioned this issue Sep 26, 2023
Closed
18 tasks
@pbking pbking mentioned this issue Sep 27, 2023
Merged
@bph bph moved this from Needs Dev / Todo to In Progress in WordPress 6.4 Editor Tasks Sep 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in WordPress 6.4 Editor Tasks Sep 28, 2023
@matiasbenedetto
Copy link
Contributor Author

Closing this as completed by:

@mikachan mikachan removed the [Status] In Progress Tracking issues with work in progress label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudhand madhusudhand

Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
4 participants
@matiasbenedetto @mikachan @jordesign @madhusudhand