Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template part has empty section in toolbar #55687

Closed
carolinan opened this issue Oct 30, 2023 · 2 comments · Fixed by #55689
Closed

Template part has empty section in toolbar #55687

carolinan opened this issue Oct 30, 2023 · 2 comments · Fixed by #55689
Assignees
Labels
[Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@carolinan
Copy link
Contributor

Description

With current Gutenberg trunk active, there is an empty section / panel in the toolbar of template parts,
between the buttons that move the block up and down and the Edit button.

Step-by-step reproduction instructions

Activate a block theme, for example, Twenty Twenty-Four.
Go to Appearance > Editor. Click on the preview to edit the current template.
Select an existing template part or add a new.
Confirm that there is an empty section in the toolbar.

Screenshots, screen recording, code snippet

Actual: there is an extra, empty section in the toolbar.
There is an empty section in the block toolbar

Expected: no empty panel in the toolbar.
Screenshot 2023-10-30 at 06 36 02

Environment info

Only tested on WP 6.4 RC 2, with and without Gutenberg trunk.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@t-hamano
Copy link
Contributor

My guess is that this problem occurs when there are no fills in the BlockControls' slots at all. For example, you can see this problem in a Group block or Columns block within a Group block with "
Inner blocks use content width" turned off.

block-controls

@Mamaduka Mamaduka added [Type] Regression Related to a regression in the latest release [Package] Block editor /packages/block-editor labels Oct 30, 2023
@Mamaduka
Copy link
Member

I think I know what caused this regression. I will look into it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants