Classic Block: Consider to make the editor keyboard shortcuts visible in the tooltips

[afercia]

In WordPress, https://core.trac.wordpress.org/changeset/38897 made some editor keyboard shortcuts more discoverable by adding them to the buttons tooltips. See also https://core.trac.wordpress.org/ticket/43773

Instead, in Gutenberg the keyboard shortcuts are not exposed in the tooltips, not even the ones in the Classic editor (which is TinyMCE):

For more details on how the shortcuts are added and translated, see src/wp-includes/js/tinymce/plugins/wordpress/plugin.js in WordPress, which gets the translations from PHP via the localized editor settings object.

Aside:
notice the positioning (and size) of the tooltips in the classic editor block (TinyMCE) is different from the one in the Gutenberg blocks.

[afercia]

Some shortcuts are now displayed in the tooltips, see #6605 and #6669. The classic block doesn't show them yet, though.

[afercia]

I'd say this should be solved, as it's important for accessibility and also because there's no feature parity with the Classic Editor. /Cc @azaozz @iseulde

[Firestorm980]

I'd like to take this one (via @10up) - cc @tofumatt

[tofumatt]

That'd be awesome 👍

[mtias]

Is this in progress?

[tofumatt]

I don't see a PR for it; I've moved it out of the 5.0 RC milestone.

[Firestorm980]

Apologies @mtias @tofumatt, I haven't been able to make much headway on this one yet.

So far I have seen the behavior of a new classic block being added having the shortcuts, but on subsequent loads not having it. It also looked like shortcuts on TinyMCE were being removed since we appear to be handling them elsewhere. I'm wondering if this removal may be partly what's causing the issue and if so, how we'd work around that since TinyMCE is probably using that to show shortcuts in its tooltips.

[tofumatt]

No worries! Thanks for the update; I'm not really aware of how those shortcuts are implemented so I'd need to check into it myself. I don't think I have the chance to do that soon so if you wanted to check out another issue for now that's cool, sorry I'm not able to devote more time to it at the moment 😢

[Firestorm980]

Fix in this PR: #12447

[Firestorm980]

@tofumatt just want to make sure this is on your radar for the PR.

[tofumatt]

Hey @Firestorm980, really sorry this fell behind in my queue, but I've assigned myself to review that PR just now and should be looking shortly. Cheers for the ping and sorry it took me forever! 😓

[timwright12]

@tofumatt just checking in on this one

[afercia]

This has been fixed in core https://core.trac.wordpress.org/ticket/35710 by @azaozz. Thinking this issue and the pending PR #12447 can be closed now.

[aduth]

This has been fixed in core https://core.trac.wordpress.org/ticket/35710 by @azaozz. Thinking this issue and the pending PR #12447 can be closed now.

In reviewing #12447 and tracing back to this note and related core commit and ticket, I'd conclude the same.