-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide meta boxes when zoomed out #66718
Comments
This doesn’t seem like a very important question/issue but I’m inviting @WordPress/gutenberg-design to weigh in. |
Thank you for bringing this up. There are several issues/PRs related to this issue, and we may need to consider them comprehensively:
My understanding is that the zoom out mode is about using patterns to roughly craft the overall content, so I don't see how necessary meta boxes are in that case. In my opinion, the ideal specifications are:
That is, I would expect the following behavior: 074dcac096aab12a58c59af86bf20f40.mp4cc @getdave @draganescu for visibility |
I'd tend to echo Aki's points above, and note that one of the primary goals of zooming out is to literally work at a receded, higher, level. Work with simpler ingredients. In that vein, hiding the metaboxes works towards that. I'd defer to folks with stronger opinions, though. |
Correct 👍 I would vote to hide metaboxes in Zoom Out. It's a view designed for composing content and not tweaking settings. |
I have the same thought. We want to keep open the tabs that relate to editing templates/pages layout and styles, I don't think metaboxes are relevant in a zoomed out context |
I should also add that I don't think we should have metaboxes for the device previews either. Those are designed as "previews" so metaboxes don't seem like a good fit there. Are there any known reasons why that would be a mistake? |
A little too late and not a blocker, just a thought: I don't know what was it so important about metaboxes showing in zoom out that required such a fast response and also merging at this stage. It's great we did it but it's an enhancement which debuted 20 hours ago and has type question 😆 It made more sense IMO exploring in trunk ways to achieve what @t-hamano shows where metaboxes are connected to all the features that would hide them. |
This may indeed be the case. However, there may be plugin developers that require meta boxes on more than just the desktop view. Pingging @arnaudbroes and @enricobattocchi: Are meta boxes necessary for tablet/mobile previews? I remember getting some feedback from you during the meta box enhancements and fixes. |
I am going to remove this issue from the 6.7 project board, having already removed #66671. |
I think it would be fairly unintuitive for users if metaboxes disappear when you toggle the tablet/mobile preview. I'm a little bit confused here though. How exactly does this new Zoom Out feature (which I really like by the way) relate to mobile previews? Imo metaboxes should be hidden for this Zoom Out feature, but not for the mobile previews, or are they one and the same? |
It may be that in the majority cases when enabling a device preview meta boxes are unwanted. However hiding them completely risks degrading any use case where a meta field influences something related to the post’s display in the editor. If the post’s template is displayed it seems more likely and perhaps with block bindings it is a possibility. Given that the meta boxes are now collapsible it seems okay to be conservative and keep them available. We could consider automatically collapsing them when a device previews is enabled if we’re sure that most of the time they’re a nuisance.
They aren’t technically related but the question seems to have been raised because of some similarity and doubt about there being any known cases where it’s useful to have them present while a device preview is active. It’s definitely something that can be considered separately. |
Thank you everyone for your feedback. So, would the following be the best course of action for now?
|
This seems like an excellent plan to me. |
Yup! That would close this issue then, yea? |
In the Post editor with a block theme active and meta boxes present, zooming out doesn’t affect the meta box pane visibility. This may be seen as unideal because displaying as much of the post content vertically as possible seems to be an aim of zoom out. Zooming out hides the editor’s footer for presumably that reason (though maybe that has more to do with content-only editing). However, not a major issue as the meta box area can be resized to take up minimal space.
Note
Availability of zoom out and meta boxes together is new in WP 6.7. If showing meta boxes while zoomed out is considered a bug then it seems eligible to fix in WP 6.7
Demo of trunk
zoom-out-and-meta-boxes.mp4
The text was updated successfully, but these errors were encountered: