Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: Add test case which will validate that blocks render properly when their definition changes #7719

Closed
gziolo opened this issue Jul 5, 2018 · 2 comments
Closed

E2E tests: Add test case which will validate that blocks render properly when their definition changes #7719

gziolo opened this issue Jul 5, 2018 · 2 comments
Assignees
@tofumatt
Labels
[Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@gziolo
Copy link
Member

gziolo commented Jul 5, 2018 •
edited
Loading

Related PR which triggered this: #7672. It would also help to discover bug in #7349. Those are only examples from this week.

We often change block definitions by adding/modifying/deleting attributes or output HTML. This causes issues when no proper backward compatibility handling is provided. We should add end-to-end test which loads all blocks (similar to Demo post) and ensures that all those blocks render properly even though blocks has changed in the meantime.
@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Backwards Compatibility Issues or PRs that impact backwards compatability labels Jul 5, 2018
@gziolo gziolo mentioned this issue Jul 5, 2018
Merged
@tofumatt tofumatt self-assigned this Jul 5, 2018
@tofumatt
Copy link
Member

tofumatt commented Jul 5, 2018

I've never written an e2e test yet and this seems like a great way to fix that. 👍

@desrosj desrosj removed the Backwards Compatibility Issues or PRs that impact backwards compatability label Oct 18, 2018
@gziolo
Copy link
Member Author

gziolo commented Apr 23, 2019

@jorgefilipecosta added basic integration for test fixtures which covers a deprecated version of two blocks (paragraph and columns). See:
https://github.com/WordPress/gutenberg/tree/master/packages/e2e-tests/fixtures/blocks

I think this is enough to consider it done. We have now an easy way to cover deprecated blocks in e2e tests.

@gziolo gziolo closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tofumatt @desrosj @gziolo