Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button on pre-publish panel is out of view #9972

Closed
oandregal opened this issue Sep 17, 2018 · 1 comment · Fixed by #9988
Closed

Close button on pre-publish panel is out of view #9972

oandregal opened this issue Sep 17, 2018 · 1 comment · Fixed by #9988
Assignees
@sarahmonster @jasmussen
Labels
Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Sep 17, 2018 •
edited
Loading

Testing instructions:

  • as an admin, change the WordPress language to german
  • log out and log in with a contributor role

For reference, this is the screen in English:

screenshot from 2018-09-17 18-27-52

This in german:

screenshot from 2018-09-17 18-26-14
@oandregal oandregal added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. labels Sep 17, 2018
jasmussen pushed a commit that referenced this issue Sep 18, 2018
Fix post-publish close button in other locales
87620c6 
Fixes #9972.

This PR makes it so the spacing that sits between the final confirm "Publish" button and the close button is a flex spacer. That means it behaves as an autosizing elastic element that has no minimum width, has a max width, and wants to be as big as it can.
@jasmussen jasmussen mentioned this issue Sep 18, 2018
Merged
jasmussen added a commit that referenced this issue Sep 18, 2018
@jasmussen
Fix post-publish close button in other locales (#9988)
bee8b55 
Fixes #9972.

This PR makes it so the spacing that sits between the final confirm "Publish" button and the close button is a flex spacer. That means it behaves as an autosizing elastic element that has no minimum width, has a max width, and wants to be as big as it can.
@sarahmonster
Copy link
Member

This should be fixed by #9398 whenever it's ready to merge. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahmonster sarahmonster

@jasmussen jasmussen

Labels
Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix post-publish close button in other locales WordPress/gutenberg
3 participants
@sarahmonster @oandregal @jasmussen