 support works in Gutenberg.
+Discover how [Meta Box](../../../docs/designers-developers/developers/backward-compatibility/meta-box.md) support works in Gutenberg.
## Theme Support
diff --git a/docs/designers-developers/developers/backward-compatibility/README.md b/docs/designers-developers/developers/backward-compatibility/README.md
new file mode 100644
index 00000000000000..bd559617c5b17f
--- /dev/null
+++ b/docs/designers-developers/developers/backward-compatibility/README.md
@@ -0,0 +1 @@
+# Backward Compatibility
diff --git a/docs/designers-developers/developers/backwards-compatibility/deprecations.md b/docs/designers-developers/developers/backward-compatibility/deprecations.md
similarity index 97%
rename from docs/designers-developers/developers/backwards-compatibility/deprecations.md
rename to docs/designers-developers/developers/backward-compatibility/deprecations.md
index 804f55c0a2c19a..7b690e995c5169 100644
--- a/docs/designers-developers/developers/backwards-compatibility/deprecations.md
+++ b/docs/designers-developers/developers/backward-compatibility/deprecations.md
@@ -1,6 +1,6 @@
# Deprecations
-Gutenberg's deprecation policy is intended to support backwards-compatibility for releases, when possible. The current deprecations are listed below and are grouped by _the version at which they will be removed completely_. If your plugin depends on these behaviors, you must update to the recommended alternative before the noted version.
+Gutenberg's deprecation policy is intended to support backward compatibility for releases, when possible. The current deprecations are listed below and are grouped by _the version at which they will be removed completely_. If your plugin depends on these behaviors, you must update to the recommended alternative before the noted version.
## 4.5.0
- `Dropdown.refresh()` has been deprecated as the contained `Popover` is now automatically refreshed.
diff --git a/docs/designers-developers/developers/backwards-compatibility/meta-box.md b/docs/designers-developers/developers/backward-compatibility/meta-box.md
similarity index 85%
rename from docs/designers-developers/developers/backwards-compatibility/meta-box.md
rename to docs/designers-developers/developers/backward-compatibility/meta-box.md
index eb96bfc38e0ffb..8e722b4cb31565 100644
--- a/docs/designers-developers/developers/backwards-compatibility/meta-box.md
+++ b/docs/designers-developers/developers/backward-compatibility/meta-box.md
@@ -21,7 +21,7 @@ WordPress will fall back to the Classic editor, where the meta box will continue
Explicitly setting `__block_editor_compatible_meta_box` to `true` will cause WordPress to stay in Gutenberg (assuming another meta box doesn't cause a fallback).
-After a meta box is converted to a block, it can be declared as existing for backwards compatibility:
+After a meta box is converted to a block, it can be declared as existing for backward compatibility:
```php
add_meta_box( 'my-meta-box', 'My Meta Box', 'my_meta_box_callback',
@@ -32,7 +32,7 @@ add_meta_box( 'my-meta-box', 'My Meta Box', 'my_meta_box_callback',
);
```
-When Gutenberg is used, this meta box will no longer be displayed in the meta box area, as it now only exists for backwards compatibility purposes. It will continue to display correctly in the Classic editor, should some other meta box cause a fallback.
+When Gutenberg is used, this meta box will no longer be displayed in the meta box area, as it now only exists for backward compatibility purposes. It will continue to display correctly in the Classic editor, should some other meta box cause a fallback.
### Meta Box Data Collection
@@ -42,7 +42,7 @@ See `lib/register.php gutenberg_trick_plugins_into_registering_meta_boxes()`
`gutenberg_collect_meta_box_data()` is hooked in later on `admin_head`. It will run through the functions and hooks that `post.php` runs to register meta boxes; namely `add_meta_boxes`, `add_meta_boxes_{$post->post_type}`, and `do_meta_boxes`.
-A copy of the global `$wp_meta_boxes` is made then filtered through `apply_filters( 'filter_gutenberg_meta_boxes', $_meta_boxes_copy );`, which will strip out any core meta boxes, standard custom taxonomy meta boxes, and any meta boxes that have declared themselves as only existing for backwards compatibility purposes.
+A copy of the global `$wp_meta_boxes` is made then filtered through `apply_filters( 'filter_gutenberg_meta_boxes', $_meta_boxes_copy );`, which will strip out any core meta boxes, standard custom taxonomy meta boxes, and any meta boxes that have declared themselves as only existing for backward compatibility purposes.
Then each location for this particular type of meta box is checked for whether it is active. If it is not empty a value of true is stored, if it is empty a value of false is stored. This meta box location data is then dispatched by the editor Redux store in `INITIALIZE_META_BOX_STATE`.
@@ -82,3 +82,5 @@ Most PHP meta boxes should continue to work in Gutenberg, but some meta boxes th
- Plugins relying on selectors that target the post title, post content fields, and other metaboxes (of the old editor).
- Plugins relying on TinyMCE's API because there's no longer a single TinyMCE instance to talk to in Gutenberg.
- Plugins making updates to their DOM on )
+
When the user selects a block, a number of control buttons may be shown in a toolbar above the selected block. Some of these block-level controls are included automatically if the editor is able to transform the block to another type, or if the focused element is an RichText component.
@@ -171,7 +171,7 @@ Note that `BlockControls` is only visible when the block is currently selected a
## Inspector
-
+
The inspector is used to display less-often-used settings or settings that require more screen space. The inspector should be used for **block-level settings only**.
diff --git a/docs/designers-developers/glossary.md b/docs/designers-developers/glossary.md
index afa574179db276..f51c0d16d5dbab 100644
--- a/docs/designers-developers/glossary.md
+++ b/docs/designers-developers/glossary.md
@@ -1,21 +1,61 @@
# Glossary
-- **Attribute sources**: An object describing the attributes shape of a block. The keys can be named as most appropriate to describe the state of a block type. The value for each key is a function which describes the strategy by which the attribute value should be extracted from the content of a saved post's content. When processed, a new object is created, taking the form of the keys defined in the attribute sources, where each value is the result of the attribute source function.
-- **Attributes**: The object representation of the current state of a block in post content. When loading a saved post, this is determined by the attribute sources for the block type. These values can change over time during an editing session when the user modifies a block, and are used when determining how to serialize the block.
-- **Block**: The abstract term used to describe units of markup that, composed together, form the content or layout of a webpage. The idea combines concepts of what in WordPress today we achieve with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience.
-- **Block Categories**: These are not a WordPress taxonomy, but instead used internally to sort blocks in the Block Inserter.
-- **Block Inserter**: Primary interface for selecting from the available blocks, triggered by plus icon buttons on Blocks or in the top-left of the editor interface.
-- **Block name**: A unique identifier for a block type, consisting of a plugin-specific namespace and a short label describing the block's intent. e.g. `core/image`
-- **Block type**: In contrast with the blocks composing a particular post, a block type describes the blueprint by which any block of that type should behave. So while there may be many images within a post, each behaves consistent with a unified image block type definition.
-- **Classic block**:
-- **Dynamic block**: A type of block where the content of which may change and cannot be determined at the time of saving a post, instead calculated any time the post is shown on the front of a site. These blocks may save fallback content or no content at all in their JavaScript implementation, instead deferring to a PHP block implementation for runtime rendering.
-- **RichText**: A common component enabling rich content editing including bold, italics, hyperlinks, etc. It is not too much unlike the single editor region of the legacy post editor, and is in fact powered by the same TinyMCE library.
-- **Inspector**: A block settings region shown in place of the post settings when a block is selected. Fields may be shown here to allow the user to customize the selected block.
-- **Post settings**: A sidebar region containing metadata fields for the post, including scheduling, visibility, terms, and featured image.
-- **Reusable block**:
-- **Sidebar**:
-- **Serialization**: The process of converting a block's attributes object into HTML markup, typically occurring when saving the post.
-- **Static block**: A type of block where the content of which is known at the time of saving a post. A static block will be saved with HTML markup directly in post content.
-- **TinyMCE**: [TinyMCE](https://www.tinymce.com/) is a web-based JavaScript WYSIWYG (What You See Is What You Get) editor.
-- **Toolbar**: A set of button controls. In the context of a block, usually referring to the toolbar of block controls shown above the selected block.
-- **Template**:
+-
+
- Attribute sources +
- An object describing the attributes shape of a block. The keys can be named as most appropriate to describe the state of a block type. The value for each key is a function which describes the strategy by which the attribute value should be extracted from the content of a saved post's content. When processed, a new object is created, taking the form of the keys defined in the attribute sources, where each value is the result of the attribute source function. + +
- Attributes +
- The object representation of the current state of a block in post content. When loading a saved post, this is determined by the attribute sources for the block type. These values can change over time during an editing session when the user modifies a block, and are used when determining how to serialize the block. + +
- Block +
- The abstract term used to describe units of markup that, composed together, form the content or layout of a webpage. The idea combines concepts of what in WordPress today we achieve with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. + +
- Block Categories +
- These are not a WordPress taxonomy, but instead used internally to sort blocks in the Block Inserter. + +
- Block Inserter +
- Primary interface for selecting from the available blocks, triggered by plus icon buttons on Blocks or in the top-left of the editor interface. + +
- Block name +
- A unique identifier for a block type, consisting of a plugin-specific namespace and a short label describing the block's intent. e.g.
core/image
+
+ - Block type +
- In contrast with the blocks composing a particular post, a block type describes the blueprint by which any block of that type should behave. So while there may be many images within a post, each behaves consistent with a unified image block type definition. + +
- Classic block +
- A block which embeds the TinyMCE editor as a block, TinyMCE was the base of the previous core editor. Older content created prior to the block editor will be loaded in to a single Classic block. + +
- Dynamic block +
- A type of block where the content of which may change and cannot be determined at the time of saving a post, instead calculated any time the post is shown on the front of a site. These blocks may save fallback content or no content at all in their JavaScript implementation, instead deferring to a PHP block implementation for runtime rendering. + +
- Inspector +
- A block settings region shown in place of the post settings when a block is selected. Fields may be shown here to allow the user to customize the selected block. + +
- Post settings +
- A sidebar region containing metadata fields for the post, including scheduling, visibility, terms, and featured image. + +
- RichText +
- A common component enabling rich content editing including bold, italics, hyperlinks, etc. It is not too much unlike the single editor region of the legacy post editor, and is in fact powered by the same TinyMCE library. + +
- Reusable block +
- A block that is saved and then can be shared as a reusable, repeatable piece of content. + +
- Sidebar +
- The panel on the right which contains the document and block settings. The sidebar is toggled using the Settings gear icon. + +
- Serialization +
- The process of converting a block's attributes object into HTML markup, which occurs each time a block is edited. + +
- Static block +
- A type of block where the content of which is known at the time of saving a post. A static block will be saved with HTML markup directly in post content. + +
- TinyMCE +
- TinyMCE is a web-based JavaScript WYSIWYG (What You See Is What You Get) editor. + +
- Toolbar +
- A set of button controls. In the context of a block, usually referring to the toolbar of block controls shown above the selected block. + +
- Template +
- A template is a pre-defined arrangement of blocks, possibly with predefined attributes or placeholder content. You can provide a template for a post type, to give users a starting point when creating a new piece of content, or inside a custom block with the
InnerBlockscomponent. See the templates documentation for more information. See templates documentation for more information.
+
+
+
$dynamic_block_name)", $routes );
- }
- }
-
- /**
- * Test getting item without permissions.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item_without_permissions() {
- wp_set_current_user( 0 );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
-
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertErrorResponse( 'gutenberg_block_cannot_read', $response, rest_authorization_required_code() );
- }
-
- /**
- * Test getting item without 'edit' context.
- */
- public function test_get_item_with_invalid_context() {
- wp_set_current_user( self::$user_id );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
- }
-
- /**
- * Test getting item with invalid block name.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item_invalid_block_name() {
- wp_set_current_user( self::$user_id );
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . 'core/123' );
-
- $request->set_param( 'context', 'edit' );
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertErrorResponse( 'rest_no_route', $response, 404 );
- }
-
- /**
- * Check getting item with an invalid param provided.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item_invalid_attribute() {
- wp_set_current_user( self::$user_id );
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
- $request->set_param(
- 'attributes',
- array(
- 'some_string' => array( 'no!' ),
- )
- );
- $response = rest_get_server()->dispatch( $request );
- $this->assertEquals( 400, $response->get_status() );
- }
-
- /**
- * Check getting item with an invalid param provided.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item_unrecognized_attribute() {
- wp_set_current_user( self::$user_id );
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
- $request->set_param(
- 'attributes',
- array(
- 'unrecognized' => 'yes',
- )
- );
- $response = rest_get_server()->dispatch( $request );
- $this->assertEquals( 400, $response->get_status() );
- }
-
- /**
- * Check getting item with default attributes provided.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item_default_attributes() {
- wp_set_current_user( self::$user_id );
-
- $block_type = WP_Block_Type_Registry::get_instance()->get_registered( self::$block_name );
- $defaults = array();
- foreach ( $block_type->attributes as $key => $attribute ) {
- if ( isset( $attribute['default'] ) ) {
- $defaults[ $key ] = $attribute['default'];
- }
- }
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
- $request->set_param( 'attributes', array() );
- $response = rest_get_server()->dispatch( $request );
- $this->assertEquals( 200, $response->get_status() );
- $data = $response->get_data();
-
- $this->assertEquals( $defaults, json_decode( $data['rendered'], true ) );
- $this->assertEquals(
- json_decode( $block_type->render( $defaults ) ),
- json_decode( $data['rendered'] )
- );
- }
-
- /**
- * Check getting item with attributes provided.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item()
- */
- public function test_get_item() {
- wp_set_current_user( self::$user_id );
-
- $block_type = WP_Block_Type_Registry::get_instance()->get_registered( self::$block_name );
- $attributes = array(
- 'some_int' => '123',
- 'some_string' => 'foo',
- 'some_array' => array( 1, '2', 3 ),
- );
-
- $expected_attributes = $attributes;
- $expected_attributes['some_int'] = (int) $expected_attributes['some_int'];
- $expected_attributes['some_array'] = array_map( 'intval', $expected_attributes['some_array'] );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
- $request->set_param( 'attributes', $attributes );
- $response = rest_get_server()->dispatch( $request );
- $this->assertEquals( 200, $response->get_status() );
- $data = $response->get_data();
-
- $this->assertEquals( $expected_attributes, json_decode( $data['rendered'], true ) );
- $this->assertEquals(
- json_decode( $block_type->render( $attributes ), true ),
- json_decode( $data['rendered'], true )
- );
- }
-
-
-
- /**
- * Check success response for getting item with layout attribute provided.
- */
- public function test_get_item_with_layout() {
- wp_set_current_user( self::$user_id );
-
- $attributes = array(
- 'layout' => 'foo',
- );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$block_name );
- $request->set_param( 'context', 'edit' );
- $request->set_param( 'attributes', $attributes );
- $response = rest_get_server()->dispatch( $request );
- $this->assertEquals( 200, $response->get_status() );
- }
-
- /**
- * Test getting item with post context.
- */
- public function test_get_item_with_post_context() {
- wp_set_current_user( self::$user_id );
-
- $expected_title = 'Test Post';
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$context_block_name );
- $request->set_param( 'context', 'edit' );
-
- // Test without post ID.
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertEquals( 200, $response->get_status() );
- $data = $response->get_data();
-
- $this->assertTrue( empty( $data['rendered'] ) );
-
- // Now test with post ID.
- $request->set_param( 'post_id', self::$post_id );
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertEquals( 200, $response->get_status() );
- $data = $response->get_data();
-
- $this->assertEquals( $expected_title, $data['rendered'] );
- }
-
- /**
- * Test getting item with invalid post ID.
- */
- public function test_get_item_without_permissions_invalid_post() {
- wp_set_current_user( self::$user_id );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$context_block_name );
- $request->set_param( 'context', 'edit' );
-
- // Test with invalid post ID.
- $request->set_param( 'post_id', PHP_INT_MAX );
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertErrorResponse( 'gutenberg_block_cannot_read', $response, 403 );
- }
-
- /**
- * Test getting item without permissions to edit context post.
- */
- public function test_get_item_without_permissions_cannot_edit_post() {
- wp_set_current_user( self::$author_id );
-
- $request = new WP_REST_Request( 'GET', self::$rest_api_route . self::$context_block_name );
- $request->set_param( 'context', 'edit' );
-
- // Test with private post ID.
- $request->set_param( 'post_id', self::$post_id );
- $response = rest_get_server()->dispatch( $request );
-
- $this->assertErrorResponse( 'gutenberg_block_cannot_read', $response, 403 );
- }
-
- /**
- * Get item schema.
- *
- * @covers WP_REST_Block_Renderer_Controller::get_item_schema()
- */
- public function test_get_item_schema() {
- $request = new WP_REST_Request( 'OPTIONS', self::$rest_api_route . self::$block_name );
- $response = rest_get_server()->dispatch( $request );
- $data = $response->get_data();
-
- $this->assertEqualSets( array( 'GET' ), $data['endpoints'][0]['methods'] );
- $this->assertEqualSets(
- array( 'name', 'context', 'attributes', 'post_id' ),
- array_keys( $data['endpoints'][0]['args'] )
- );
- $this->assertEquals( 'object', $data['endpoints'][0]['args']['attributes']['type'] );
-
- $this->assertArrayHasKey( 'schema', $data );
- $this->assertEquals( 'rendered-block', $data['schema']['title'] );
- $this->assertEquals( 'object', $data['schema']['type'] );
- $this->arrayHasKey( 'rendered', $data['schema']['properties'] );
- $this->arrayHasKey( 'string', $data['schema']['properties']['rendered']['type'] );
- $this->assertEquals( array( 'edit' ), $data['schema']['properties']['rendered']['context'] );
- }
-
- public function test_update_item() {
- $this->markTestSkipped( 'Controller doesn\'t implement update_item().' );
- }
-
- public function test_create_item() {
- $this->markTestSkipped( 'Controller doesn\'t implement create_item().' );
- }
-
- public function test_delete_item() {
- $this->markTestSkipped( 'Controller doesn\'t implement delete_item().' );
- }
-
- public function test_get_items() {
- $this->markTestSkipped( 'Controller doesn\'t implement get_items().' );
- }
-
- public function test_context_param() {
- $this->markTestSkipped( 'Controller doesn\'t implement context_param().' );
- }
-
- public function test_prepare_item() {
- $this->markTestSkipped( 'Controller doesn\'t implement prepare_item().' );
- }
-}
diff --git a/phpunit/class-rest-blocks-controller-test.php b/phpunit/class-rest-blocks-controller-test.php
deleted file mode 100644
index 5a9e71af7e33e9..00000000000000
--- a/phpunit/class-rest-blocks-controller-test.php
+++ /dev/null
@@ -1,204 +0,0 @@
- 'wp_block',
- 'post_status' => 'publish',
- 'post_title' => 'My cool block',
- 'post_content' => '
` );
+ expect( await getEditedPostContent() ).toMatch( regExp );
+ } );
+} );
diff --git a/test/e2e/specs/classic-editor.test.js b/test/e2e/specs/classic-editor.test.js
deleted file mode 100644
index 0d51c93e5b3420..00000000000000
--- a/test/e2e/specs/classic-editor.test.js
+++ /dev/null
@@ -1,25 +0,0 @@
-/**
- * Internal dependencies
- */
-import { visitAdmin } from '../support/utils';
-
-describe( 'classic editor', () => {
- beforeAll( async () => {
- await visitAdmin( 'post-new.php', 'classic-editor' );
- } );
-
- it( 'Should work properly', async () => {
- // Click visual editor
- await expect( page ).toClick( '#content-tmce' );
- await expect( page ).toClick( '#content_ifr' );
-
- // type some random text
- await page.keyboard.type( 'Typing in classic editor' );
-
- // Switch to HTML mode
- await expect( page ).toClick( '#content-html' );
-
- const textEditorContent = await page.$eval( '.wp-editor-area', ( element ) => element.value );
- expect( textEditorContent ).toEqual( 'Typing in classic editor' );
- } );
-} );
diff --git a/test/e2e/specs/font-size-picker.test.js b/test/e2e/specs/font-size-picker.test.js
index 4a55dd3e0dbc83..42bfe7e17f5a49 100644
--- a/test/e2e/specs/font-size-picker.test.js
+++ b/test/e2e/specs/font-size-picker.test.js
@@ -5,6 +5,7 @@ import {
clickBlockAppender,
getEditedPostContent,
newPost,
+ pressTimes,
} from '../support/utils';
describe( 'Font Size Picker', () => {
@@ -32,7 +33,8 @@ describe( 'Font Size Picker', () => {
await page.keyboard.type( 'Paragraph to be made "small"' );
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.type( '13' );
+ // This should be the "small" font-size of the current theme.
+ await page.keyboard.type( '19.5' );
// Ensure content matches snapshot.
const content = await getEditedPostContent();
@@ -58,7 +60,8 @@ describe( 'Font Size Picker', () => {
await page.keyboard.type( 'Paragraph with font size reset using button' );
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.type( '13' );
+ // This should be the default font-size of the current theme.
+ await page.keyboard.type( '22' );
// Blur the range control
await page.click( '.components-base-control__label' );
@@ -80,9 +83,10 @@ describe( 'Font Size Picker', () => {
const changeSizeButton = await page.waitForSelector( '.components-button.is-font-large' );
await changeSizeButton.click();
+ // Clear the custom font size input.
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.press( 'Backspace' );
- await page.keyboard.press( 'Backspace' );
+ await pressTimes( 'ArrowRight', 4 );
+ await pressTimes( 'Backspace', 4 );
// Ensure content matches snapshot.
const content = await getEditedPostContent();
diff --git a/test/e2e/specs/new-post.test.js b/test/e2e/specs/new-post.test.js
index da171371330db4..44e08f1902f2dd 100644
--- a/test/e2e/specs/new-post.test.js
+++ b/test/e2e/specs/new-post.test.js
@@ -2,12 +2,19 @@
* Internal dependencies
*/
import { newPost } from '../support/utils';
+import { activatePlugin, deactivatePlugin } from '../support/plugins';
describe( 'new editor state', () => {
beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-post-formats-support' );
await newPost();
} );
+ afterAll( async () => {
+ await newPost();
+ await deactivatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ } );
+
it( 'should show the New Post page in Gutenberg', async () => {
expect( page.url() ).toEqual( expect.stringContaining( 'post-new.php' ) );
// Should display the blank title.
diff --git a/test/e2e/specs/rich-text.test.js b/test/e2e/specs/rich-text.test.js
index dca248c8289314..2f1012766444fd 100644
--- a/test/e2e/specs/rich-text.test.js
+++ b/test/e2e/specs/rich-text.test.js
@@ -67,4 +67,75 @@ describe( 'RichText', () => {
expect( await getEditedPostContent() ).toMatchSnapshot();
} );
+
+ it( 'should only mutate text data on input', async () => {
+ await clickBlockAppender();
+ await page.keyboard.type( '1' );
+ await pressWithModifier( 'primary', 'b' );
+ await page.keyboard.type( '2' );
+ await pressWithModifier( 'primary', 'b' );
+ await page.keyboard.type( '3' );
+
+ await page.evaluate( () => {
+ let called;
+ const { body } = document;
+ const config = {
+ attributes: true,
+ childList: true,
+ characterData: true,
+ subtree: true,
+ };
+
+ const mutationObserver = new MutationObserver( ( records ) => {
+ if ( called || records.length > 1 ) {
+ throw new Error( 'Typing should only mutate once.' );
+ }
+
+ records.forEach( ( record ) => {
+ if ( record.type !== 'characterData' ) {
+ throw new Error(
+ `Typing mutated more than character data: ${ record.type }`
+ );
+ }
+ } );
+
+ called = true;
+ } );
+
+ mutationObserver.observe( body, config );
+
+ window.unsubscribes = [ () => mutationObserver.disconnect() ];
+
+ document.addEventListener( 'selectionchange', () => {
+ function throwMultipleSelectionChange() {
+ throw new Error( 'Typing should only emit one selection change event.' );
+ }
+
+ document.addEventListener(
+ 'selectionchange',
+ throwMultipleSelectionChange,
+ { once: true }
+ );
+
+ window.unsubscribes.push( () => {
+ document.removeEventListener( 'selectionchange', throwMultipleSelectionChange );
+ } );
+ }, { once: true } );
+ } );
+
+ await page.keyboard.type( '4' );
+
+ await page.evaluate( () => {
+ // The selection change event should be called once. If there's only
+ // one item in `window.unsubscribes`, it means that only one
+ // function is present to disconnect the `mutationObserver`.
+ if ( window.unsubscribes.length === 1 ) {
+ throw new Error( 'The selection change event listener was never called.' );
+ }
+
+ window.unsubscribes.forEach( ( unsubscribe ) => unsubscribe() );
+ } );
+
+ expect( await getEditedPostContent() ).toMatchSnapshot();
+ } );
} );
diff --git a/test/e2e/specs/templates.test.js b/test/e2e/specs/templates.test.js
index 9b5d22080e0d42..4d8d16e9ce9513 100644
--- a/test/e2e/specs/templates.test.js
+++ b/test/e2e/specs/templates.test.js
@@ -72,8 +72,14 @@ describe( 'templates', () => {
await switchToTestUser();
}
- beforeAll( async () => await setPostFormat( 'image' ) );
- afterAll( async () => await setPostFormat( STANDARD_FORMAT_VALUE ) );
+ beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ await setPostFormat( 'image' );
+ } );
+ afterAll( async () => {
+ await setPostFormat( STANDARD_FORMAT_VALUE );
+ await deactivatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ } );
it( 'should populate new post with default block for format', async () => {
await newPost();
diff --git a/test/e2e/specs/wp-editor-meta-box.test.js b/test/e2e/specs/wp-editor-meta-box.test.js
new file mode 100644
index 00000000000000..496057bb55c1cf
--- /dev/null
+++ b/test/e2e/specs/wp-editor-meta-box.test.js
@@ -0,0 +1,38 @@
+/**
+ * Internal dependencies
+ */
+import { newPost, publishPost } from '../support/utils';
+import { activatePlugin, deactivatePlugin } from '../support/plugins';
+
+describe( 'WP Editor Meta Boxes', () => {
+ beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-wp-editor-meta-box' );
+ await newPost();
+ } );
+
+ afterAll( async () => {
+ await deactivatePlugin( 'gutenberg-test-plugin-wp-editor-meta-box' );
+ } );
+
+ it( 'Should save the changes', async () => {
+ // Add title to enable valid non-empty post save.
+ await page.type( '.editor-post-title__input', 'Hello Meta' );
+
+ // Type something
+ await page.click( '#test_tinymce_id-html' );
+ await page.type( '#test_tinymce_id', 'Typing in a metabox' );
+ await page.click( '#test_tinymce_id-tmce' );
+
+ await publishPost();
+
+ await page.reload();
+
+ await page.click( '#test_tinymce_id-html' );
+ const content = await page.$eval(
+ '#test_tinymce_id',
+ ( textarea ) => textarea.value
+ );
+
+ expect( content ).toMatchSnapshot();
+ } );
+} );
diff --git a/test/e2e/specs/writing-flow.test.js b/test/e2e/specs/writing-flow.test.js
index bcad1f3d55bb0c..7c4197755bab81 100644
--- a/test/e2e/specs/writing-flow.test.js
+++ b/test/e2e/specs/writing-flow.test.js
@@ -44,6 +44,8 @@ describe( 'adding blocks', () => {
// Arrow up in inner blocks should navigate through (1) column wrapper,
// (2) text fields.
+ // We need to arrow up key presses in the paragraph block because it shows up in two lines.
+ await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'ArrowUp' );
activeElementText = await page.evaluate( () => document.activeElement.textContent );
@@ -53,6 +55,7 @@ describe( 'adding blocks', () => {
// columns wrappers before escaping out.
let activeElementBlockType;
await page.keyboard.press( 'ArrowUp' );
+ await page.keyboard.press( 'ArrowUp' );
activeElementBlockType = await page.evaluate( () => (
document.activeElement.getAttribute( 'data-type' )
) );
diff --git a/test/e2e/support/plugins.js b/test/e2e/support/plugins.js
index da9edd3656860f..f8d64a7a1ec175 100644
--- a/test/e2e/support/plugins.js
+++ b/test/e2e/support/plugins.js
@@ -11,7 +11,7 @@ import { visitAdmin, switchToAdminUser, switchToTestUser } from './utils';
*/
export async function installPlugin( slug, searchTerm ) {
await switchToAdminUser();
- await visitAdmin( 'plugin-install.php?s=' + encodeURIComponent( searchTerm || slug ) + '&tab=search&type=term' );
+ await visitAdmin( 'plugin-install.php', 's=' + encodeURIComponent( searchTerm || slug ) + '&tab=search&type=term' );
await page.click( '.install-now[data-slug="' + slug + '"]' );
await page.waitForSelector( '.activate-now[data-slug="' + slug + '"]' );
await switchToTestUser();
diff --git a/test/e2e/test-plugins/post-formats.php b/test/e2e/test-plugins/post-formats.php
new file mode 100644
index 00000000000000..b0fdec68947fcb
--- /dev/null
+++ b/test/e2e/test-plugins/post-formats.php
@@ -0,0 +1,15 @@
+ID, 'test_tinymce', true );
+ wp_editor( $field_value, 'test_tinymce_id', array(
+ 'wpautop' => true,
+ 'media_buttons' => false,
+ 'textarea_name' => 'test_tinymce',
+ 'textarea_rows' => 10,
+ 'teeny' => true
+ ) );
+ }, null, 'advanced', 'high' );
+});
+add_action( 'save_post', function( $post_id ){
+ if ( ! isset( $_POST['test_tinymce'] ) ) {
+ return;
+ }
+ update_post_meta( $post_id, 'test_tinymce', $_POST['test_tinymce'] );
+});
setState( { hovered: true } ) }
+ onMouseLeave={ () => setState( { hovered: false } ) }
+ >
);
}
export default compose(
+ withState( { hovered: false } ),
withSelect( ( select, ownProps ) => {
const { getBlockCount, getBlockName, isBlockValid, getEditorSettings, getTemplateLock } = select( 'core/editor' );
diff --git a/packages/editor/src/components/default-block-appender/test/__snapshots__/index.js.snap b/packages/editor/src/components/default-block-appender/test/__snapshots__/index.js.snap
index df9daeebd54f21..dc26d4405d8636 100644
--- a/packages/editor/src/components/default-block-appender/test/__snapshots__/index.js.snap
+++ b/packages/editor/src/components/default-block-appender/test/__snapshots__/index.js.snap
@@ -4,6 +4,8 @@ exports[`DefaultBlockAppender should append a default block when input focused 1
Hello!
', - ) - ); - - self::$user_ids = array( - 'editor' => $factory->user->create( array( 'role' => 'editor' ) ), - 'author' => $factory->user->create( array( 'role' => 'author' ) ), - 'contributor' => $factory->user->create( array( 'role' => 'contributor' ) ), - ); - } - - /** - * Delete our fake data after our tests run. - */ - public static function wpTearDownAfterClass() { - wp_delete_post( self::$post_id ); - - foreach ( self::$user_ids as $user_id ) { - self::delete_user( $user_id ); - } - } - - /** - * Test cases for test_capabilities(). - */ - public function data_capabilities() { - return array( - array( 'create', 'editor', 201 ), - array( 'create', 'author', 201 ), - array( 'create', 'contributor', 403 ), - array( 'create', null, 401 ), - - array( 'read', 'editor', 200 ), - array( 'read', 'author', 200 ), - array( 'read', 'contributor', 200 ), - array( 'read', null, 401 ), - - array( 'update_delete_own', 'editor', 200 ), - array( 'update_delete_own', 'author', 200 ), - array( 'update_delete_own', 'contributor', 403 ), - - array( 'update_delete_others', 'editor', 200 ), - array( 'update_delete_others', 'author', 403 ), - array( 'update_delete_others', 'contributor', 403 ), - array( 'update_delete_others', null, 401 ), - ); - } - - /** - * Exhaustively check that each role either can or cannot create, edit, - * update, and delete reusable blocks. - * - * @dataProvider data_capabilities - */ - public function test_capabilities( $action, $role, $expected_status ) { - if ( $role ) { - $user_id = self::$user_ids[ $role ]; - wp_set_current_user( $user_id ); - } else { - wp_set_current_user( 0 ); - } - - switch ( $action ) { - case 'create': - $request = new WP_REST_Request( 'POST', '/wp/v2/blocks' ); - $request->set_body_params( - array( - 'title' => 'Test', - 'content' => 'Test
', - ) - ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - break; - - case 'read': - $request = new WP_REST_Request( 'GET', '/wp/v2/blocks/' . self::$post_id ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - break; - - case 'update_delete_own': - $post_id = wp_insert_post( - array( - 'post_type' => 'wp_block', - 'post_status' => 'publish', - 'post_title' => 'My cool block', - 'post_content' => 'Hello!
', - 'post_author' => $user_id, - ) - ); - - $request = new WP_REST_Request( 'PUT', '/wp/v2/blocks/' . $post_id ); - $request->set_body_params( - array( - 'title' => 'Test', - 'content' => 'Test
', - ) - ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - $request = new WP_REST_Request( 'DELETE', '/wp/v2/blocks/' . $post_id ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - wp_delete_post( $post_id ); - - break; - - case 'update_delete_others': - $request = new WP_REST_Request( 'PUT', '/wp/v2/blocks/' . self::$post_id ); - $request->set_body_params( - array( - 'title' => 'Test', - 'content' => 'Test
', - ) - ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - $request = new WP_REST_Request( 'DELETE', '/wp/v2/blocks/' . self::$post_id ); - - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( $expected_status, $response->get_status() ); - - break; - - default: - $this->fail( "'$action' is not a valid action." ); - } - } - - /** - * Check that the raw title and content of a block can be accessed when there - * is no set schema, and that the rendered content of a block is not included - * in the response. - */ - public function test_content() { - wp_set_current_user( self::$user_ids['author'] ); - - $request = new WP_REST_Request( 'GET', '/wp/v2/blocks/' . self::$post_id ); - $response = rest_get_server()->dispatch( $request ); - $data = $response->get_data(); - - $this->assertEquals( - array( - 'raw' => 'My cool block', - ), - $data['title'] - ); - $this->assertEquals( - array( - 'raw' => 'Hello!
', - 'protected' => false, - ), - $data['content'] - ); - } -} diff --git a/phpunit/class-rest-search-controller-test.php b/phpunit/class-rest-search-controller-test.php deleted file mode 100644 index 26649037e8ff22..00000000000000 --- a/phpunit/class-rest-search-controller-test.php +++ /dev/null @@ -1,521 +0,0 @@ -post->create_many( - 4, - array( - 'post_title' => 'my-footitle', - 'post_type' => 'post', - ) - ); - - self::$my_title_page_ids = $factory->post->create_many( - 4, - array( - 'post_title' => 'my-footitle', - 'post_type' => 'page', - ) - ); - - self::$my_content_post_ids = $factory->post->create_many( - 6, - array( - 'post_content' => 'my-foocontent', - ) - ); - } - - /** - * Delete our fake data after our tests run. - */ - public static function wpTearDownAfterClass() { - $post_ids = array_merge( - self::$my_title_post_ids, - self::$my_title_page_ids, - self::$my_content_post_ids - ); - - foreach ( $post_ids as $post_id ) { - wp_delete_post( $post_id, true ); - } - } - - /** - * Check that our routes get set up properly. - */ - public function test_register_routes() { - $routes = rest_get_server()->get_routes(); - - $this->assertArrayHasKey( '/wp/v2/search', $routes ); - $this->assertCount( 1, $routes['/wp/v2/search'] ); - } - - /** - * Check the context parameter. - */ - public function test_context_param() { - $response = $this->do_request_with_params( array(), 'OPTIONS' ); - $data = $response->get_data(); - - $this->assertEquals( 'view', $data['endpoints'][0]['args']['context']['default'] ); - $this->assertEquals( array( 'view', 'embed' ), $data['endpoints'][0]['args']['context']['enum'] ); - } - - /** - * Search through all content. - */ - public function test_get_items() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - array_merge( - self::$my_title_post_ids, - self::$my_title_page_ids, - self::$my_content_post_ids - ), - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through all content with a low limit. - */ - public function test_get_items_with_limit() { - $response = $this->do_request_with_params( - array( - 'per_page' => 3, - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEquals( 3, count( $response->get_data() ) ); - } - - /** - * Search through posts of any post type. - */ - public function test_get_items_search_type_post() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'post', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - array_merge( - self::$my_title_post_ids, - self::$my_title_page_ids, - self::$my_content_post_ids - ), - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through posts of post type 'post'. - */ - public function test_get_items_search_type_post_subtype_post() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'post', - 'subtype' => 'post', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - array_merge( - self::$my_title_post_ids, - self::$my_content_post_ids - ), - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through posts of post type 'page'. - */ - public function test_get_items_search_type_post_subtype_page() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'post', - 'subtype' => 'page', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - self::$my_title_page_ids, - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through an invalid type - */ - public function test_get_items_search_type_invalid() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'invalid', - ) - ); - - $this->assertErrorResponse( 'rest_invalid_param', $response, 400 ); - } - - /** - * Search through posts of an invalid post type. - */ - public function test_get_items_search_type_post_subtype_invalid() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'post', - 'subtype' => 'invalid', - ) - ); - - $this->assertErrorResponse( 'rest_invalid_param', $response, 400 ); - } - - /** - * Search through posts and pages. - */ - public function test_get_items_search_posts_and_pages() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'type' => 'post', - 'subtype' => 'post,page', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - array_merge( - self::$my_title_post_ids, - self::$my_title_page_ids, - self::$my_content_post_ids - ), - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through all that matches a 'footitle' search. - */ - public function test_get_items_search_for_footitle() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'search' => 'footitle', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - array_merge( - self::$my_title_post_ids, - self::$my_title_page_ids - ), - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Search through all that matches a 'foocontent' search. - */ - public function test_get_items_search_for_foocontent() { - $response = $this->do_request_with_params( - array( - 'per_page' => 100, - 'search' => 'foocontent', - ) - ); - - $this->assertEquals( 200, $response->get_status() ); - $this->assertEqualSets( - self::$my_content_post_ids, - wp_list_pluck( $response->get_data(), 'id' ) - ); - } - - /** - * Test retrieving a single item isn't possible. - */ - public function test_get_item() { - /** The search controller does not allow getting individual item content */ - $request = new WP_REST_Request( 'GET', '/wp/v2/search' . self::$my_title_post_ids[0] ); - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( 404, $response->get_status() ); - } - - /** - * Test creating an item isn't possible. - */ - public function test_create_item() { - /** The search controller does not allow creating content */ - $request = new WP_REST_Request( 'POST', '/wp/v2/search' ); - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( 404, $response->get_status() ); - } - - /** - * Test updating an item isn't possible. - */ - public function test_update_item() { - /** The search controller does not allow upading content */ - $request = new WP_REST_Request( 'POST', '/wp/v2/search' . self::$my_title_post_ids[0] ); - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( 404, $response->get_status() ); - } - - /** - * Test deleting an item isn't possible. - */ - public function test_delete_item() { - /** The search controller does not allow deleting content */ - $request = new WP_REST_Request( 'DELETE', '/wp/v2/search' . self::$my_title_post_ids[0] ); - $response = rest_get_server()->dispatch( $request ); - $this->assertEquals( 404, $response->get_status() ); - } - - /** - * Test preparing the data contains the correct fields. - */ - public function test_prepare_item() { - $response = $this->do_request_with_params(); - $this->assertEquals( 200, $response->get_status() ); - - $data = $response->get_data(); - $this->assertEquals( - array( - 'id', - 'title', - 'url', - 'type', - 'subtype', - '_links', - ), - array_keys( $data[0] ) - ); - } - - /** - * Test preparing the data with limited fields contains the correct fields. - */ - public function test_prepare_item_limit_fields() { - if ( ! method_exists( 'WP_REST_Controller', 'get_fields_for_response' ) ) { - $this->markTestSkipped( 'Limiting fields requires the WP_REST_Controller::get_fields_for_response() method.' ); - } - - $response = $this->do_request_with_params( - array( - '_fields' => 'id,title', - ) - ); - $this->assertEquals( 200, $response->get_status() ); - - $data = $response->get_data(); - $this->assertEquals( - array( - 'id', - 'title', - '_links', - ), - array_keys( $data[0] ) - ); - } - - /** - * Tests the item schema is correct. - */ - public function test_get_item_schema() { - $request = new WP_REST_Request( 'OPTIONS', '/wp/v2/search' ); - $response = rest_get_server()->dispatch( $request ); - $data = $response->get_data(); - $properties = $data['schema']['properties']; - - $this->assertArrayHasKey( 'id', $properties ); - $this->assertArrayHasKey( 'title', $properties ); - $this->assertArrayHasKey( 'url', $properties ); - $this->assertArrayHasKey( 'type', $properties ); - $this->assertArrayHasKey( 'subtype', $properties ); - } - - /** - * Tests that non-public post types are not allowed. - */ - public function test_non_public_post_type() { - $response = $this->do_request_with_params( - array( - 'type' => 'post', - 'subtype' => 'post,nav_menu_item', - ) - ); - $this->assertErrorResponse( 'rest_invalid_param', $response, 400 ); - } - - /** - * Test getting items directly with a custom search handler. - */ - public function test_custom_search_handler_get_items() { - $controller = new WP_REST_Search_Controller( array( new WP_REST_Dummy_Search_Handler( 10 ) ) ); - - $request = $this->get_request( - array( - 'page' => 1, - 'per_page' => 10, - 'type' => 'dummy', - 'subtype' => array( WP_REST_Search_Controller::TYPE_ANY ), - ) - ); - $response = $controller->get_items( $request ); - $this->assertEqualSets( range( 1, 10 ), wp_list_pluck( $response->get_data(), 'id' ) ); - - $request = $this->get_request( - array( - 'page' => 1, - 'per_page' => 10, - 'type' => 'dummy', - 'subtype' => array( 'dummy_first_type' ), - ) - ); - $response = $controller->get_items( $request ); - $this->assertEqualSets( range( 1, 5 ), wp_list_pluck( $response->get_data(), 'id' ) ); - } - - /** - * Test preparing an item directly with a custom search handler. - */ - public function test_custom_search_handler_prepare_item() { - $controller = new WP_REST_Search_Controller( array( new WP_REST_Dummy_Search_Handler( 10 ) ) ); - - $request = $this->get_request( - array( - 'type' => 'dummy', - 'subtype' => array( WP_REST_Search_Controller::TYPE_ANY ), - ) - ); - $response = $controller->prepare_item_for_response( 1, $request ); - $data = $response->get_data(); - $this->assertEquals( - array( - 'id', - 'title', - 'url', - 'type', - 'subtype', - ), - array_keys( $data ) - ); - } - - /** - * Test preparing an item directly with a custom search handler with limited fields. - */ - public function test_custom_search_handler_prepare_item_limit_fields() { - if ( ! method_exists( 'WP_REST_Controller', 'get_fields_for_response' ) ) { - $this->markTestSkipped( 'Limiting fields requires the WP_REST_Controller::get_fields_for_response() method.' ); - } - - $controller = new WP_REST_Search_Controller( array( new WP_REST_Dummy_Search_Handler( 10 ) ) ); - - $request = $this->get_request( - array( - 'type' => 'dummy', - 'subtype' => array( WP_REST_Search_Controller::TYPE_ANY ), - '_fields' => 'id,title', - ) - ); - $response = $controller->prepare_item_for_response( 1, $request ); - $data = $response->get_data(); - $this->assertEquals( - array( - 'id', - 'title', - ), - array_keys( $data ) - ); - } - - /** - * Test getting the collection params directly with a custom search handler. - */ - public function test_custom_search_handler_get_collection_params() { - $controller = new WP_REST_Search_Controller( array( new WP_REST_Dummy_Search_Handler( 10 ) ) ); - - $params = $controller->get_collection_params(); - $this->assertEquals( 'dummy', $params[ WP_REST_Search_Controller::PROP_TYPE ]['default'] ); - $this->assertEqualSets( array( 'dummy' ), $params[ WP_REST_Search_Controller::PROP_TYPE ]['enum'] ); - $this->assertEqualSets( array( 'dummy_first_type', 'dummy_second_type', WP_REST_Search_Controller::TYPE_ANY ), $params[ WP_REST_Search_Controller::PROP_SUBTYPE ]['items']['enum'] ); - } - - /** - * Perform a REST request to our search endpoint with given parameters. - */ - private function do_request_with_params( $params = array(), $method = 'GET' ) { - $request = $this->get_request( $params, $method ); - - return rest_get_server()->dispatch( $request ); - } - - /** - * Get a REST request object for given parameters. - */ - private function get_request( $params = array(), $method = 'GET' ) { - $request = new WP_REST_Request( $method, '/wp/v2/search' ); - - foreach ( $params as $param => $value ) { - $request->set_param( $param, $value ); - } - - return $request; - } -} diff --git a/test/e2e/specs/__snapshots__/rich-text.test.js.snap b/test/e2e/specs/__snapshots__/rich-text.test.js.snap index e911f407edd680..275080b436f2da 100644 --- a/test/e2e/specs/__snapshots__/rich-text.test.js.snap +++ b/test/e2e/specs/__snapshots__/rich-text.test.js.snap @@ -24,6 +24,12 @@ exports[`RichText should handle change in tag name gracefully 1`] = ` " `; +exports[`RichText should only mutate text data on input 1`] = ` +" +1234
+" +`; + exports[`RichText should transform backtick to code 1`] = ` "A backtick
Typing in a metabox
"`; diff --git a/test/e2e/specs/blocks/__snapshots__/classic.test.js.snap b/test/e2e/specs/blocks/__snapshots__/classic.test.js.snap new file mode 100644 index 00000000000000..a4461344bb4384 --- /dev/null +++ b/test/e2e/specs/blocks/__snapshots__/classic.test.js.snap @@ -0,0 +1,3 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Classic should be inserted 1`] = `"test"`; diff --git a/test/e2e/specs/blocks/classic.test.js b/test/e2e/specs/blocks/classic.test.js new file mode 100644 index 00000000000000..f0b733b4a9947d --- /dev/null +++ b/test/e2e/specs/blocks/classic.test.js @@ -0,0 +1,73 @@ +/** + * External dependencies + */ +import path from 'path'; +import fs from 'fs'; +import os from 'os'; +import uuid from 'uuid/v4'; + +/** + * Internal dependencies + */ +import { + getEditedPostContent, + newPost, + insertBlock, + pressWithModifier, +} from '../../support/utils'; + +describe( 'Classic', () => { + beforeEach( async () => { + await newPost(); + } ); + + it( 'should be inserted', async () => { + await insertBlock( 'Classic' ); + // Wait for TinyMCE to initialise. + await page.waitForSelector( '.mce-content-body' ); + // Ensure there is focus. + await page.focus( '.mce-content-body' ); + await page.keyboard.type( 'test' ); + // Move focus away. + await pressWithModifier( 'shift', 'Tab' ); + + expect( await getEditedPostContent() ).toMatchSnapshot(); + } ); + + it( 'should insert media', async () => { + await insertBlock( 'Classic' ); + // Wait for TinyMCE to initialise. + await page.waitForSelector( '.mce-content-body' ); + // Ensure there is focus. + await page.focus( '.mce-content-body' ); + await page.keyboard.type( 'test' ); + + // Click the image button. + await page.waitForSelector( 'div[aria-label="Add Media"]' ); + await page.click( 'div[aria-label="Add Media"]' ); + + // Wait for media modal to appear and upload image. + await page.waitForSelector( '.media-modal input[type=file]' ); + const inputElement = await page.$( '.media-modal input[type=file]' ); + const testImagePath = path.join( __dirname, '..', '..', 'assets', '10x10_e2e_test_image_z9T8jK.png' ); + const filename = uuid(); + const tmpFileName = path.join( os.tmpdir(), filename + '.png' ); + fs.copyFileSync( testImagePath, tmpFileName ); + await inputElement.uploadFile( tmpFileName ); + + // Wait for upload. + await page.waitForSelector( `.media-modal li[aria-label="${ filename }"]` ); + + // Insert the uploaded image. + await page.click( '.media-modal button.media-button-insert' ); + + // Wait for image to be inserted. + await page.waitForSelector( '.mce-content-body img' ); + + // Move focus away. + await pressWithModifier( 'shift', 'Tab' ); + + const regExp = new RegExp( `test` );
+ expect( await getEditedPostContent() ).toMatch( regExp );
+ } );
+} );
diff --git a/test/e2e/specs/classic-editor.test.js b/test/e2e/specs/classic-editor.test.js
deleted file mode 100644
index 0d51c93e5b3420..00000000000000
--- a/test/e2e/specs/classic-editor.test.js
+++ /dev/null
@@ -1,25 +0,0 @@
-/**
- * Internal dependencies
- */
-import { visitAdmin } from '../support/utils';
-
-describe( 'classic editor', () => {
- beforeAll( async () => {
- await visitAdmin( 'post-new.php', 'classic-editor' );
- } );
-
- it( 'Should work properly', async () => {
- // Click visual editor
- await expect( page ).toClick( '#content-tmce' );
- await expect( page ).toClick( '#content_ifr' );
-
- // type some random text
- await page.keyboard.type( 'Typing in classic editor' );
-
- // Switch to HTML mode
- await expect( page ).toClick( '#content-html' );
-
- const textEditorContent = await page.$eval( '.wp-editor-area', ( element ) => element.value );
- expect( textEditorContent ).toEqual( 'Typing in classic editor' );
- } );
-} );
diff --git a/test/e2e/specs/font-size-picker.test.js b/test/e2e/specs/font-size-picker.test.js
index 4a55dd3e0dbc83..42bfe7e17f5a49 100644
--- a/test/e2e/specs/font-size-picker.test.js
+++ b/test/e2e/specs/font-size-picker.test.js
@@ -5,6 +5,7 @@ import {
clickBlockAppender,
getEditedPostContent,
newPost,
+ pressTimes,
} from '../support/utils';
describe( 'Font Size Picker', () => {
@@ -32,7 +33,8 @@ describe( 'Font Size Picker', () => {
await page.keyboard.type( 'Paragraph to be made "small"' );
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.type( '13' );
+ // This should be the "small" font-size of the current theme.
+ await page.keyboard.type( '19.5' );
// Ensure content matches snapshot.
const content = await getEditedPostContent();
@@ -58,7 +60,8 @@ describe( 'Font Size Picker', () => {
await page.keyboard.type( 'Paragraph with font size reset using button' );
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.type( '13' );
+ // This should be the default font-size of the current theme.
+ await page.keyboard.type( '22' );
// Blur the range control
await page.click( '.components-base-control__label' );
@@ -80,9 +83,10 @@ describe( 'Font Size Picker', () => {
const changeSizeButton = await page.waitForSelector( '.components-button.is-font-large' );
await changeSizeButton.click();
+ // Clear the custom font size input.
await page.click( '.blocks-font-size .components-range-control__number' );
- await page.keyboard.press( 'Backspace' );
- await page.keyboard.press( 'Backspace' );
+ await pressTimes( 'ArrowRight', 4 );
+ await pressTimes( 'Backspace', 4 );
// Ensure content matches snapshot.
const content = await getEditedPostContent();
diff --git a/test/e2e/specs/new-post.test.js b/test/e2e/specs/new-post.test.js
index da171371330db4..44e08f1902f2dd 100644
--- a/test/e2e/specs/new-post.test.js
+++ b/test/e2e/specs/new-post.test.js
@@ -2,12 +2,19 @@
* Internal dependencies
*/
import { newPost } from '../support/utils';
+import { activatePlugin, deactivatePlugin } from '../support/plugins';
describe( 'new editor state', () => {
beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-post-formats-support' );
await newPost();
} );
+ afterAll( async () => {
+ await newPost();
+ await deactivatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ } );
+
it( 'should show the New Post page in Gutenberg', async () => {
expect( page.url() ).toEqual( expect.stringContaining( 'post-new.php' ) );
// Should display the blank title.
diff --git a/test/e2e/specs/rich-text.test.js b/test/e2e/specs/rich-text.test.js
index dca248c8289314..2f1012766444fd 100644
--- a/test/e2e/specs/rich-text.test.js
+++ b/test/e2e/specs/rich-text.test.js
@@ -67,4 +67,75 @@ describe( 'RichText', () => {
expect( await getEditedPostContent() ).toMatchSnapshot();
} );
+
+ it( 'should only mutate text data on input', async () => {
+ await clickBlockAppender();
+ await page.keyboard.type( '1' );
+ await pressWithModifier( 'primary', 'b' );
+ await page.keyboard.type( '2' );
+ await pressWithModifier( 'primary', 'b' );
+ await page.keyboard.type( '3' );
+
+ await page.evaluate( () => {
+ let called;
+ const { body } = document;
+ const config = {
+ attributes: true,
+ childList: true,
+ characterData: true,
+ subtree: true,
+ };
+
+ const mutationObserver = new MutationObserver( ( records ) => {
+ if ( called || records.length > 1 ) {
+ throw new Error( 'Typing should only mutate once.' );
+ }
+
+ records.forEach( ( record ) => {
+ if ( record.type !== 'characterData' ) {
+ throw new Error(
+ `Typing mutated more than character data: ${ record.type }`
+ );
+ }
+ } );
+
+ called = true;
+ } );
+
+ mutationObserver.observe( body, config );
+
+ window.unsubscribes = [ () => mutationObserver.disconnect() ];
+
+ document.addEventListener( 'selectionchange', () => {
+ function throwMultipleSelectionChange() {
+ throw new Error( 'Typing should only emit one selection change event.' );
+ }
+
+ document.addEventListener(
+ 'selectionchange',
+ throwMultipleSelectionChange,
+ { once: true }
+ );
+
+ window.unsubscribes.push( () => {
+ document.removeEventListener( 'selectionchange', throwMultipleSelectionChange );
+ } );
+ }, { once: true } );
+ } );
+
+ await page.keyboard.type( '4' );
+
+ await page.evaluate( () => {
+ // The selection change event should be called once. If there's only
+ // one item in `window.unsubscribes`, it means that only one
+ // function is present to disconnect the `mutationObserver`.
+ if ( window.unsubscribes.length === 1 ) {
+ throw new Error( 'The selection change event listener was never called.' );
+ }
+
+ window.unsubscribes.forEach( ( unsubscribe ) => unsubscribe() );
+ } );
+
+ expect( await getEditedPostContent() ).toMatchSnapshot();
+ } );
} );
diff --git a/test/e2e/specs/templates.test.js b/test/e2e/specs/templates.test.js
index 9b5d22080e0d42..4d8d16e9ce9513 100644
--- a/test/e2e/specs/templates.test.js
+++ b/test/e2e/specs/templates.test.js
@@ -72,8 +72,14 @@ describe( 'templates', () => {
await switchToTestUser();
}
- beforeAll( async () => await setPostFormat( 'image' ) );
- afterAll( async () => await setPostFormat( STANDARD_FORMAT_VALUE ) );
+ beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ await setPostFormat( 'image' );
+ } );
+ afterAll( async () => {
+ await setPostFormat( STANDARD_FORMAT_VALUE );
+ await deactivatePlugin( 'gutenberg-test-plugin-post-formats-support' );
+ } );
it( 'should populate new post with default block for format', async () => {
await newPost();
diff --git a/test/e2e/specs/wp-editor-meta-box.test.js b/test/e2e/specs/wp-editor-meta-box.test.js
new file mode 100644
index 00000000000000..496057bb55c1cf
--- /dev/null
+++ b/test/e2e/specs/wp-editor-meta-box.test.js
@@ -0,0 +1,38 @@
+/**
+ * Internal dependencies
+ */
+import { newPost, publishPost } from '../support/utils';
+import { activatePlugin, deactivatePlugin } from '../support/plugins';
+
+describe( 'WP Editor Meta Boxes', () => {
+ beforeAll( async () => {
+ await activatePlugin( 'gutenberg-test-plugin-wp-editor-meta-box' );
+ await newPost();
+ } );
+
+ afterAll( async () => {
+ await deactivatePlugin( 'gutenberg-test-plugin-wp-editor-meta-box' );
+ } );
+
+ it( 'Should save the changes', async () => {
+ // Add title to enable valid non-empty post save.
+ await page.type( '.editor-post-title__input', 'Hello Meta' );
+
+ // Type something
+ await page.click( '#test_tinymce_id-html' );
+ await page.type( '#test_tinymce_id', 'Typing in a metabox' );
+ await page.click( '#test_tinymce_id-tmce' );
+
+ await publishPost();
+
+ await page.reload();
+
+ await page.click( '#test_tinymce_id-html' );
+ const content = await page.$eval(
+ '#test_tinymce_id',
+ ( textarea ) => textarea.value
+ );
+
+ expect( content ).toMatchSnapshot();
+ } );
+} );
diff --git a/test/e2e/specs/writing-flow.test.js b/test/e2e/specs/writing-flow.test.js
index bcad1f3d55bb0c..7c4197755bab81 100644
--- a/test/e2e/specs/writing-flow.test.js
+++ b/test/e2e/specs/writing-flow.test.js
@@ -44,6 +44,8 @@ describe( 'adding blocks', () => {
// Arrow up in inner blocks should navigate through (1) column wrapper,
// (2) text fields.
+ // We need to arrow up key presses in the paragraph block because it shows up in two lines.
+ await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'ArrowUp' );
activeElementText = await page.evaluate( () => document.activeElement.textContent );
@@ -53,6 +55,7 @@ describe( 'adding blocks', () => {
// columns wrappers before escaping out.
let activeElementBlockType;
await page.keyboard.press( 'ArrowUp' );
+ await page.keyboard.press( 'ArrowUp' );
activeElementBlockType = await page.evaluate( () => (
document.activeElement.getAttribute( 'data-type' )
) );
diff --git a/test/e2e/support/plugins.js b/test/e2e/support/plugins.js
index da9edd3656860f..f8d64a7a1ec175 100644
--- a/test/e2e/support/plugins.js
+++ b/test/e2e/support/plugins.js
@@ -11,7 +11,7 @@ import { visitAdmin, switchToAdminUser, switchToTestUser } from './utils';
*/
export async function installPlugin( slug, searchTerm ) {
await switchToAdminUser();
- await visitAdmin( 'plugin-install.php?s=' + encodeURIComponent( searchTerm || slug ) + '&tab=search&type=term' );
+ await visitAdmin( 'plugin-install.php', 's=' + encodeURIComponent( searchTerm || slug ) + '&tab=search&type=term' );
await page.click( '.install-now[data-slug="' + slug + '"]' );
await page.waitForSelector( '.activate-now[data-slug="' + slug + '"]' );
await switchToTestUser();
diff --git a/test/e2e/test-plugins/post-formats.php b/test/e2e/test-plugins/post-formats.php
new file mode 100644
index 00000000000000..b0fdec68947fcb
--- /dev/null
+++ b/test/e2e/test-plugins/post-formats.php
@@ -0,0 +1,15 @@
+ID, 'test_tinymce', true );
+ wp_editor( $field_value, 'test_tinymce_id', array(
+ 'wpautop' => true,
+ 'media_buttons' => false,
+ 'textarea_name' => 'test_tinymce',
+ 'textarea_rows' => 10,
+ 'teeny' => true
+ ) );
+ }, null, 'advanced', 'high' );
+});
+add_action( 'save_post', function( $post_id ){
+ if ( ! isset( $_POST['test_tinymce'] ) ) {
+ return;
+ }
+ update_post_meta( $post_id, 'test_tinymce', $_POST['test_tinymce'] );
+});