From f43f32021d91ed213852ec0d8e8210d0fdce80a3 Mon Sep 17 00:00:00 2001
From: Jorge <jorge.costa@developer.pt>
Date: Tue, 5 Feb 2019 12:51:21 +0000
Subject: [PATCH] Make the modal title styling consistent

---
 packages/components/src/modal/style.scss                  | 4 ++--
 .../src/components/keyboard-shortcut-help-modal/index.js  | 8 +-------
 .../components/keyboard-shortcut-help-modal/style.scss    | 4 ----
 .../test/__snapshots__/index.js.snap                      | 8 +-------
 packages/edit-post/src/components/options-modal/index.js  | 2 +-
 .../edit-post/src/components/options-modal/style.scss     | 5 -----
 .../options-modal/test/__snapshots__/index.js.snap        | 8 +-------
 7 files changed, 6 insertions(+), 33 deletions(-)

diff --git a/packages/components/src/modal/style.scss b/packages/components/src/modal/style.scss
index 99a76a85598c7..2058155f1f132 100644
--- a/packages/components/src/modal/style.scss
+++ b/packages/components/src/modal/style.scss
@@ -81,8 +81,8 @@
 	}
 
 	.components-modal__header-heading {
-		font-size: 1em;
-		font-weight: 400;
+		font-size: 1rem;
+		font-weight: 600;
 	}
 
 	h1 {
diff --git a/packages/edit-post/src/components/keyboard-shortcut-help-modal/index.js b/packages/edit-post/src/components/keyboard-shortcut-help-modal/index.js
index 0eae08393a7cb..810519ccd3a49 100644
--- a/packages/edit-post/src/components/keyboard-shortcut-help-modal/index.js
+++ b/packages/edit-post/src/components/keyboard-shortcut-help-modal/index.js
@@ -69,12 +69,6 @@ const ShortcutSection = ( { title, shortcuts } ) => (
 );
 
 export function KeyboardShortcutHelpModal( { isModalActive, toggleModal } ) {
-	const title = (
-		<span className="edit-post-keyboard-shortcut-help__title">
-			{ __( 'Keyboard Shortcuts' ) }
-		</span>
-	);
-
 	return (
 		<Fragment>
 			<KeyboardShortcuts
@@ -86,7 +80,7 @@ export function KeyboardShortcutHelpModal( { isModalActive, toggleModal } ) {
 			{ isModalActive && (
 				<Modal
 					className="edit-post-keyboard-shortcut-help"
-					title={ title }
+					title={ __( 'Keyboard Shortcuts' ) }
 					closeLabel={ __( 'Close' ) }
 					onRequestClose={ toggleModal }
 				>
diff --git a/packages/edit-post/src/components/keyboard-shortcut-help-modal/style.scss b/packages/edit-post/src/components/keyboard-shortcut-help-modal/style.scss
index 9bb49eee5c189..da56dc8704582 100644
--- a/packages/edit-post/src/components/keyboard-shortcut-help-modal/style.scss
+++ b/packages/edit-post/src/components/keyboard-shortcut-help-modal/style.scss
@@ -1,8 +1,4 @@
 .edit-post-keyboard-shortcut-help {
-	&__title {
-		font-size: 1rem;
-		font-weight: 600;
-	}
 
 	&__section {
 		margin: 0 0 2rem 0;
diff --git a/packages/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap b/packages/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap
index 65d9ef3a52aaf..fe522a985d3b9 100644
--- a/packages/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap
+++ b/packages/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap
@@ -14,13 +14,7 @@ exports[`KeyboardShortcutHelpModal should match snapshot when the modal is activ
     className="edit-post-keyboard-shortcut-help"
     closeLabel="Close"
     onRequestClose={[Function]}
-    title={
-      <span
-        className="edit-post-keyboard-shortcut-help__title"
-      >
-        Keyboard Shortcuts
-      </span>
-    }
+    title="Keyboard Shortcuts"
   >
     <ShortcutSection
       key="0"
diff --git a/packages/edit-post/src/components/options-modal/index.js b/packages/edit-post/src/components/options-modal/index.js
index 1d6528815b59c..76cf40a74cd92 100644
--- a/packages/edit-post/src/components/options-modal/index.js
+++ b/packages/edit-post/src/components/options-modal/index.js
@@ -33,7 +33,7 @@ export function OptionsModal( { isModalActive, isViewable, closeModal } ) {
 	return (
 		<Modal
 			className="edit-post-options-modal"
-			title={ <span className="edit-post-options-modal__title">{ __( 'Options' ) }</span> }
+			title={ __( 'Options' ) }
 			closeLabel={ __( 'Close' ) }
 			onRequestClose={ closeModal }
 		>
diff --git a/packages/edit-post/src/components/options-modal/style.scss b/packages/edit-post/src/components/options-modal/style.scss
index 28916c0be35e5..62b827d104ecd 100644
--- a/packages/edit-post/src/components/options-modal/style.scss
+++ b/packages/edit-post/src/components/options-modal/style.scss
@@ -1,9 +1,4 @@
 .edit-post-options-modal {
-	&__title {
-		font-size: 1rem;
-		font-weight: 600;
-	}
-
 	&__section {
 		margin: 0 0 2rem 0;
 	}
diff --git a/packages/edit-post/src/components/options-modal/test/__snapshots__/index.js.snap b/packages/edit-post/src/components/options-modal/test/__snapshots__/index.js.snap
index 94d989e492e4a..a81252b32b95f 100644
--- a/packages/edit-post/src/components/options-modal/test/__snapshots__/index.js.snap
+++ b/packages/edit-post/src/components/options-modal/test/__snapshots__/index.js.snap
@@ -4,13 +4,7 @@ exports[`OptionsModal should match snapshot when the modal is active 1`] = `
 <WithInstanceId(Modal)
   className="edit-post-options-modal"
   closeLabel="Close"
-  title={
-    <span
-      className="edit-post-options-modal__title"
-    >
-      Options
-    </span>
-  }
+  title="Options"
 >
   <Section
     title="General"