Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert/top toolbar tab order #20571

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Revert/top toolbar tab order #20571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71d8334
Revert "Fix e2e tests"
ellatrix Mar 2, 2020
c54cf41
Revert "Top toolbar: adjust tab order"
ellatrix Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/editor/various/a11y.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe( 'a11y', () => {
':focus',
( focusedElement ) => {
return focusedElement.classList.contains(
'editor-post-publish-button__button'
'block-editor-inserter__toggle'
);
}
);
Expand Down
8 changes: 4 additions & 4 deletions packages/edit-post/src/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ function Header() {

return (
<div className="edit-post-header">
<div className="edit-post-header__toolbar">
<FullscreenModeClose />
<HeaderToolbar />
</div>
<div className="edit-post-header__settings">
{ ! isPublishSidebarOpened && (
// This button isn't completely hidden by the publish sidebar.
Expand Down Expand Up @@ -93,10 +97,6 @@ function Header() {
<PinnedPlugins.Slot />
<MoreMenu />
</div>
<div className="edit-post-header__toolbar">
<FullscreenModeClose />
<HeaderToolbar />
</div>
</div>
);
}
Expand Down
1 change: 0 additions & 1 deletion packages/edit-post/src/components/header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
background: $white;
display: flex;
flex-wrap: wrap;
flex-direction: row-reverse;
justify-content: space-between;
align-items: center;
// The header should never be wider than the viewport, or buttons might be hidden. Especially relevant at high zoom levels. Related to https://core.trac.wordpress.org/ticket/47603#ticket.
Expand Down