Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix movers in full-wide. #21097

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix movers in full-wide. #21097

merged 1 commit into from
Mar 27, 2020

Commits on Mar 27, 2020

  1. Fix movers in full-wide. 

    Fixes #20451. Props @lgersman for advice.

The mover control did not work for full-wide images. I'm honestly surprised it worked in wide and normal settings, because the z-index was -1 meaning it shouldn't be. I suspect it's because the layout canvas has padding left and right that somehow interferes with things here, but couldn't verify.

However the negative z index wasn't a good fix in the first place. The reason it was there, was to make sure that when the mover control animates out, it appears to be coming from "beneath" the block toolbar. The z-index put it below the entire block toolbar, which is the container that has a background color.

This PR changes things so the mover control does not have a z-index, but the switcher button has been elevated, and been given a white background color to cover it.
    @jasmussen
    jasmussen committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f410dfc View commit details
    Browse the repository at this point in the history