[Mobile] Pass the Gallery v2 Flag over from the editor #33314

…ocks at the point that the block validation is run

… innerBlocks at the point that the block validation is run" This reverts commit 4d95e95.

… available at point of block validation

… gallery - with the idea that we will improve the innerblocks drag and drop in a later PR

This reverts commit 9b0abcc.

…existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR" This reverts commit cc05d60.

…e drop zone

…transform when dragging multiple images onto the gallery

…e selection

…ponent state

…mponent some times

… is async so need to keep circling through the innerblocks updates until we have all the data we need

…mages have data resolved

…27087) * Add loading spinner for image size options Co-authored-by: Glen Davies <glen.davies@a8c.com>

The imageEdit component defaults the context value for allowResize to true. The refactored gallery sets this to false by default. Setting allowResize to false when migrating a deprecated gallery allows images to be cropped in the display the same as the gallery when the post is saved and gallery reloaded.

…ole on a list item

Also tweaks the gallery styles to remove the margins the use of `wp-block-image` introduces when it is moved to the inner `figure` element.

…that some previous block versions may not have an ids attribute

…ones ending up display flex instead of hidden

This reverts commit e0723a7.

This reverts commit a7504fd.

…x css instead

… use flex css instead

…ons (#27855) Co-authored-by: Glen Davies <glen.davies@a8c.com>

…pplied (#27869) * Add alignment fixes for non cropped images Co-authored-by: Glen Davies <glen.davies@a8c.com>

… block lifecycle

…tedAttributes set

…ny custom links

Co-authored-by: Glen Davies <glen.davies@a8c.com>

…e the innerBlocks as part of transform

…cated to user that change was made to all images in the gallery

…drop files handled by transform

…attributes handled by gallery

Reasoning for removal can be found at #25940 (comment)

…gallery images

…child image updates and allow single undo to revert

…useEffect (#29328) Co-authored-by: Glen Davies <glen.davies@a8c.com>

…umber of images the same, but list of images different to current.

This allows the shallow equals check in the inner blocks' `useNestedSettingsUpdate` hook to pass successfully preventing the state update loop.

…the media library needs the image ids to reconcile which images are already in the gallery

Co-authored-by: Glen Davies <glen.davies@a8c.com>

) Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>

…er 'Upload' button

…d to stop link settings being lost when images edited (#30550) Co-authored-by: Glen Davies <glen.davies@a8c.com>

… existing images have no ids

Co-authored-by: Glen Davies <glen.davies@a8c.com>

… with existing themes and plugins (#30710) Co-authored-by: Glen Davies <glen.davies@a8c.com>

… gallery with existing themes and plugins (#30710)" This reverts commit a2253ec.

Co-authored-by: Glen Davies <glen.davies@a8c.com>

…t stealing focus every time block is selected (#31216) Co-authored-by: Glen Davies <glen.davies@a8c.com>

Co-authored-by: Glen Davies <glen.davies@a8c.com>

This is only temporary, for testing purposes. This will be replaced with an actual implementation (which will need to access the flag remotely).

This will need to be addressed (since we can't have unwrapped text on mobile). For now, I'm commenting this out to proceed with cherry-picking the changes from the original mobile refactor branch.

Some of these "fixes" are simply disabling lint for the offending lines. These currently unused variables may be used in a later PR, so I'm leaving them in, for now, to help simplify reconciling the changes from the former refactor PR.

…refactor/gallery-as-nested-image-blocks

…gallery-to-nested-image-blocks # Conflicts: # lib/experiments-page.php # packages/block-library/src/gallery/edit.js # packages/block-library/src/gallery/gallery.js # packages/block-library/src/image/block.json

…refactor/gallery-as-nested-image-blocks

* WIP-commit bring image changes from final state of original mobile PR This has unresolved / unmarked conflicts which will be resolve in subsequent commits. I am separating the commit to make the resolution process more transparent. * Remove duplicate / conflicting methods from performance refactor * Use context for imageCrop and isGrouped instead of isGallery * Remove non-existent inheritedAttributes attribute * Remove dead code from non-existent context attributes * Remove unused attributes prop from link settings

Note: Since render was changed to renderContent, we should return early from render too, when blockWidth is falsey.

I'm not sure yet whether it still makes sense to use blockProps in this way. I'm going to cherry-pick the commits by file, and sort out the need for this mechanism afterwards.

Since this is duplicated from the original mobile gallery code (Tiles component), it might make sense to export it for re-use. Previously, it was only moved, but now that we will maintain both versions, it has become a duplicate implementation. I will defer this to a later commit.

Similar to blockProps mentioned earlier, gridProperties will be evaluated after cherry-picking the relevant changes, to see if there is another mechanism that may be more appropriate.

Note: This also re-adds fullWidth style, which is still being used in both v1 and v2 mobile implementations. If this is superceded by a recent refactor of the block width styles, it may be worth revisiting this and removing / changing the implementation.

Note: as before, blockProps and gridProperties should be re-evaluated in subsequent commits, if necessary. E.g. `imageCrop` is already recieved via context, and `isGroup` may be sufficient, eliminating the need for `isGallery`.

Going back over the older commits, it seems there were a two strategies used to render the gallery images as a grid. One used the numColumns (same as used in the Columns block), and the other using the Grid component. This commit cleans up the unused parts of the former approach.

This is no longer necessary, since we are using context to pass gallery-level attributes to the image blocks' rendering.

* Give content precedence over flag in edit wrapper This modifies the logic in the gallery edit wrapper function to infer version information from existing content when the editor encounters content created from the new implementation and the flag is not set.

…refactor/gallery-as-nested-image-blocks

…tream Leaving conflict markers in so the resolutions can be evaluated in the subsequent commit.

This brings the gallery edit changes to the v1 directory, and merges the changes for the image block.

…rnmobile/refactor/gallery-as-nested-image-blocks

This brings the same change from this PR: #31027 which may have missed the deprecated hook in the refactor PR, since it hadn't landed yet.

…refactor/gallery-as-nested-image-blocks

…tream Merging with conflict unresolved to make resolution reviewable in the following commit.

This was an update for a new jsdoc linting rule.

…rnmobile/refactor/gallery-as-nested-image-blocks

I believe this was inadvertantly removed in some earlier commits, so this commit adds it back.

These flags allow for a slightly more flexible, performant, and terse way of branching by platform. For more details, see: #18058 (comment)

This is necessary for unit tests, because they instantiate the block's edit component directly, and so the default context is not provided.

This will be reverted once the block settings are fetched from the REST API. This is enabled for now for testing purposes.

This reverts commit 6fbaed9.

…tream Merging with conflict unresolved to make resolution reviewable in the following commit.

The conflict was from #33095

…rnmobile/refactor/gallery-as-nested-image-blocks

* Reward experiments description * Add documentation about new media placeholder handleUpload flag * Add additional explanation of v1-6 deprecations * Rename the edit wrapper components to make useage clearer * Temporarily remove tranform from v1 gallery to v2 gallery

…erBlocks

…locks

* Remove the imageCount attribute and use CSS instead to set default columns Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>

…gallery-to-nested-image-blocks # Conflicts: # packages/block-library/src/gallery/style.scss

…refactor/gallery-as-nested-image-blocks

…rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2

…33816) * Renames __experimentalGalleryRefactor to __unstableGalleryWithImageBlocks * Fixes lint formatting issue * Fixes lint issue

…locks-editor-settings_v2

…refactor PR(#31306) * Move native v1 Gallery components to v1 directory * Use v1 defaultColumnsNumber in native v1 gallery * Make onFocus optional in MediaPlaceholder * Add useInnerBlocksProps hook * Enable __experimentalGalleryRefactor flag under __DEV__ * Add numColumns to block-list flat list * Fix spacing * Adjust styles to avoid appender overlap * Add gallery caption * Fix lint Some of these "fixes" are simply disabling lint for the offending lines. These currently unused variables may be used in a later PR, so I'm leaving them in, for now, to help simplify reconciling the changes from the former refactor PR. * Fix sass lint * [Mobile] - Refactor gallery - cherry pick image edit native (#31826) * Remove duplicate / conflicting methods from performance refactor * Use context for imageCrop and isGrouped instead of isGallery * Remove non-existent inheritedAttributes attribute * Remove dead code from non-existent context attributes * Remove unused attributes prop from link settings * Cherry-pick BlockListItem changes Note: Since render was changed to renderContent, we should return early from render too, when blockWidth is falsey. * Return early from render instead of renderContent * Cherry-pick plumb blockProps through BlockListBlock I'm not sure yet whether it still makes sense to use blockProps in this way. I'm going to cherry-pick the commits by file, and sort out the need for this mechanism afterwards. * Cherry-pick add GridItem Since this is duplicated from the original mobile gallery code (Tiles component), it might make sense to export it for re-use. Previously, it was only moved, but now that we will maintain both versions, it has become a duplicate implementation. I will defer this to a later commit. * Cherry-pick BlockList Similar to blockProps mentioned earlier, gridProperties will be evaluated after cherry-picking the relevant changes, to see if there is another mechanism that may be more appropriate. * Cherry-pick StylePreview key change * Cherry-pick blockProps and gridProperties in InnerBlocks * Use sass var for galleryAppender padding Note: This also re-adds fullWidth style, which is still being used in both v1 and v2 mobile implementations. If this is superceded by a recent refactor of the block width styles, it may be worth revisiting this and removing / changing the implementation. * Cherry-pick remaining gallery changes Note: as before, blockProps and gridProperties should be re-evaluated in subsequent commits, if necessary. E.g. `imageCrop` is already recieved via context, and `isGroup` may be sufficient, eliminating the need for `isGallery`. * Remove numColumns Going back over the older commits, it seems there were a two strategies used to render the gallery images as a grid. One used the numColumns (same as used in the Columns block), and the other using the Grid component. This commit cleans up the unused parts of the former approach. * Remove blockProps This is no longer necessary, since we are using context to pass gallery-level attributes to the image blocks' rendering. * Fix gallery block.json (delete extra comma) * Remove unused imageCrop * Add back blockWidth contentContainerStyles in block list * Use boolean flags for variants in Platform module These flags allow for a slightly more flexible, performant, and terse way of branching by platform. For more details, see: #18058 (comment) * Use boolean Platform flags * Only render imageSizeOptions loading spinner on web * Add default for destructured context in image edit This is necessary for unit tests, because they instantiate the block's edit component directly, and so the default context is not provided. * Temporarily hard-code experimenal gallery refactor flag to true This will be reverted once the block settings are fetched from the REST API. This is enabled for now for testing purposes. * Update experiments page with warning about the mobile app version * Changes new gallery flag name * Updates mobile warning * Removes the imageCount attribute * Remove the isGrouped context * Fixes lint issue Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com>

…gallery-to-nested-image-blocks

…refactor/gallery-as-nested-image-blocks-editor-settings_v2

…locks-editor-settings_v2

Pass the Gallery v2 Flag over from the editor on Android

…locks-editor-settings_v2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mobile] Pass the Gallery v2 Flag over from the editor #33314

[Mobile] Pass the Gallery v2 Flag over from the editor #33314

Commits on Apr 11, 2021

Commits on Apr 12, 2021

Commits on Apr 13, 2021

Commits on Apr 22, 2021

Commits on Apr 23, 2021

Commits on Apr 28, 2021

Commits on Apr 29, 2021

Commits on Apr 30, 2021

Commits on May 4, 2021

Commits on May 7, 2021

Commits on May 19, 2021

Commits on May 20, 2021

Commits on May 27, 2021

Commits on May 30, 2021

Commits on May 31, 2021

Commits on Jun 3, 2021

Commits on Jun 9, 2021

Commits on Jun 15, 2021

Commits on Jun 16, 2021

Commits on Jul 5, 2021

Commits on Jul 8, 2021

Commits on Jul 9, 2021

Commits on Jul 16, 2021

Commits on Jul 19, 2021

Commits on Jul 20, 2021

Commits on Jul 22, 2021

Commits on Jul 26, 2021

Commits on Jul 27, 2021

Commits on Jul 28, 2021

Commits on Aug 2, 2021

Commits on Aug 3, 2021

Commits on Aug 4, 2021

Commits on Aug 30, 2021

Commits on Sep 1, 2021

Commits on Sep 2, 2021