Try: Polish post takeover modal. #37821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One option is to land this PR as is, as a small step forward that doesn't close out #37725, but still vastly improves the situation 🤔 |
|
Size Change: -37 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I've not tested this, but we can use
Makes sense to me 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starts work on #37725 (comment). Before:
After:
Note that a number of aspects aren't yet implemented, not for lack of desire but I need to read up on (or get help with) how to piece together complex strings for localization. These include:
In diving into this work, it also highlights some of the changes we need to happen at the component level, so the content of modals can be systematically the same without bespoke CSS. That would also benefit the Page List conversion modal, which this PR also bases its max-width on:
Such component changes are out of scope for this PR, but are nevertheless worth mentioning.
How has this been tested?
Create two admin user accounts, for example an editor and an admin. Save a post as one user, then log in as the other user in an incognito window and load the same post.
Checklist:
*.native.jsfiles for terms that need renaming or removal).