[RNMobile] Increase editor ready timeout in Android e2e tests #39315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
geriux
approved these changes
Mar 11, 2022
fluiddot
deleted the
rnmobile/fix/increase-editor-ready-timeout-e2e-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reduce failure rate of the
React Native E2E Tests (Android)PR check.Why?
After merging #39098, I noticed that several commits merged into
trunkhave the PR checkReact Native E2E Tests (Android)marked as failed (around 42% of recent commits). This PR should reduce the flakiness and hopefully prevent that PR check to fail.How?
As far as I investigated, the issue looks related to the tests not waiting enough time before acting over the app. Currently, the Android E2E tests wait 5 seconds, this PR increases the timeout to 8 seconds in order to give enough time to let the editor be ready.
Testing Instructions
This fix has been tested in #39247 by running several times the CI job and checking that all of them passed.
As you can see in the screenshot, a couple of runs failed but were not related to e2e tests:
Screenshots or screencast