Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate block editor insert usage to preferences store #39632

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Open

Migrate block editor insert usage to preferences store #39632

wants to merge 12 commits into from

Commits on Jul 18, 2024

  1. Migrate block editor insert usage to preferences store 

    Update tests

Make updateInsertUsage a proper action that can be unit tested

Fix reusable block tests

Update test

Try fixing private actions with new store registration

Update tests

Add special handling for the insertUsage migration as it was performed later than others

Remove unused function

Add mark next change as expensive action to preferences store

Update debounce function to handle a longer debounce for expensive changes

Mark the insertUsage preference change as expensive

Make expensive calls use a trailing edge debounce

Fix duplicate keys in tests

Improve trailing edge test

Fix tests, and ensure options object is optional

Make updateInsertUsage a private API

Make markNextChangeAsExpensive a private API

Update docs

Update package-lock

Opt-in preferences as a core module using private apis

Do not unlock what is already unlocked

Remove time property from INSERT_BLOCKS and REPLACE_BLOCKS action objects

Rename `match` to `variation`

Rename file to create-async-debouncer

Add an extra param for defining the debounce of expensive requests

Add a default value of `false` for the `isExpensive` option

Make `__unstableGetInsertUsage` a private selector called `getInsertUsage`. Remove `__unstableGetInsertUsageForBlock`

Only run the migration when needed

Keep the `insertUsage` data at a maximum of 100 records

Fix linting issues

Update docs
    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b7746d5 View commit details
    Browse the repository at this point in the history

  2. Fix block editor actions tests

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7b77cf8 View commit details
    Browse the repository at this point in the history

  3. Fix frecency test

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c248301 View commit details
    Browse the repository at this point in the history

  4. Minimize properties in test assertions

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    35f769f View commit details
    Browse the repository at this point in the history

  5. Ensure markNextChangeAsExpensive is called and update tests

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0973730 View commit details
    Browse the repository at this point in the history

  6. Fix only track allowedBlocks in insertBlocks action

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    776ce33 View commit details
    Browse the repository at this point in the history

  7. Simplify sort callback

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    01c8545 View commit details
    Browse the repository at this point in the history

  8. Update debouncing function - use trailing edge debounce only and impl… 

    …ement a maxWait
    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e53f940 View commit details
    Browse the repository at this point in the history

  9. Fix persistence layer tests

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    152c653 View commit details
    Browse the repository at this point in the history

  10. Update docs

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8535582 View commit details
    Browse the repository at this point in the history

  11. Fix resetting of preferences in e2e test

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ff68aa1 View commit details
    Browse the repository at this point in the history

  12. Hide the welcome guide in e2e test

    @talldan
    talldan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f33d99c View commit details
    Browse the repository at this point in the history