Use the post-title as the featured-image's alt text when linked to the post #39634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Type] Bug
aristath
commented
Mar 22, 2022
|
Size Change: +1.78 kB (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Mar 22, 2022
|
The code looks good. The post title won't always match the description of the featured image, but it might be preferable over missing alt text. /cc @alexstine |
Agreed. Since it's a link to the post and not the image, it makes more sense to use the post-title and not the image's alt text. |
|
Matches guidelines by w3.org:
|
Mamaduka
approved these changes
Mar 22, 2022
alexstine
reviewed
Mar 23, 2022
|
@aristath Overall, this is a super simple but helpful change. Thanks for your work on this. Especially in the front-end context. 👍 |
|
@alexstine I made the suggested edits on the alt-text for the editor, so I'll ahead and merge this one. |
t-hamano
added
the
[Block] Post Featured Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the post-title as the alt-text of a featured image, when that image links to the post.
Why?
We use
get_the_post_thumbnail()to get the post-thumbnail, and display it. That function callswp_get_attachment_image()to generate the HTML. The problem here, is thatwp_get_attachment_imageuses the image's metadata to get the alt-text. As a result of that, assistive technologies announce the image's alt text (if one even exists) for the link, and that is not what it should be.The link points to the post, and therefore should have the post-title as alt description, instead of the image's alt description. The image does not describe the link, the post-title does.
How?
Added a 3rd argument to the
get_the_post_thumbnail()call, defining thealtattribute as the post-title.Testing Instructions
In the twentytwentytwo theme, add a post with a featured image, and then confirm that on the frontpage the post-title is used as the image's alt text when the post-thumbnail is a link to the post itself.