Chrome: Hide several Sidebar Panels if the CPT doesn't support it #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
General Interface
youknowriad
force-pushed
the
update/featured-image-support
branch
from
76b4c9e to
cceab01
Compare
youknowriad
force-pushed
the
update/featured-image-support
branch
from
cceab01 to
6f27c2b
Compare
youknowriad
changed the title
youknowriad
force-pushed
the
update/featured-image-support
branch
from
7ea49bc to
097b3a0
Compare
jorgefilipecosta
approved these changes
Dec 28, 2017
| @@ -16,7 +16,9 @@ import { compose } from '@wordpress/element'; | |||
| import { getCurrentPostType } from '../../store/selectors'; | |||
|
|
|||
| function PostTypeSupportCheck( { postType, children, supportKey } ) { | |||
There was a problem hiding this comment.
Maybe the supportKey should be named supportKeys given that we accept more than one.
youknowriad
force-pushed
the
update/featured-image-support
branch
from
097b3a0 to
0fe2322
Compare
aduth
reviewed
Jan 3, 2018
| function PostTypeSupportCheck( { postType, children, supportKey } ) { | ||
| const isSupported = get( postType, [ 'data', 'supports', supportKey ], false ); | ||
| function PostTypeSupportCheck( { postType, children, supportKeys } ) { | ||
| const isSupported = some( |
There was a problem hiding this comment.
Should this be every? I could imagine a need for both cases, i.e. a component that requires post type support for both X and Y, but alternatively X or Y.
There was a problem hiding this comment.
I hesitated on adding an "operator". For now we only have the "or" use-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3989
This PR hides the featured image panel on CPT not supporting it.
Testing instructions