ESLint: Disable jest rules for storybook playwright #47141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Automated Testing
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
flootr,
chad1008,
ntsekouras and
brookewp
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 788048a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3910317417
|
Mamaduka
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #47065 we enabled
jestrecommended ESLint rules for our tests.However, I just noticed that there are a couple of false positives in the storybook playwright specs. They're false positives since they reference the playwright test runner, not the jest one.
This PR disables that directory from being linted with the ESLint rules for tests.
Why?
To fix the related ESLint errors, see the screenshot below.
How?
We're just altering our ESLint config to disable
jest,@testing-libraryandjest-domrules for the storywright playwright directory.Testing Instructions
Run
npm run lint:jsand verify there are no errors.Testing Instructions for Keyboard
None
Screenshots or screencast